Congratulations!

[Valid RSS] This is a valid RSS feed.

Recommendations

This feed is valid, but interoperability with the widest range of feed readers could be improved by implementing the following recommendations.

Source: http://bbpress.trac.wordpress.org/ticket/3434?format=rss

  1. <?xml version="1.0"?>
  2. <rss xmlns:dc="http://purl.org/dc/elements/1.1/" version="2.0">
  3.  <channel>
  4.    <title>bbPress Trac: Ticket #3434: Akismet catches spam for moderator, but moderators are able to bypass spam</title>
  5.    <link>https://bbpress.trac.wordpress.org/ticket/3434</link>
  6.    <description>&lt;p&gt;
  7. In the Akismet module, moderators are able to bypass Akismet checks:
  8. &lt;a class="ext-link" href="https://github.com/bbpress/bbPress/blob/09313c9984c55429f3e664ca4383768b68ee34b9/src/includes/extend/akismet.php#L205-L211"&gt;&lt;span class="icon"&gt;​&lt;/span&gt;https://github.com/bbpress/bbPress/blob/09313c9984c55429f3e664ca4383768b68ee34b9/src/includes/extend/akismet.php#L205-L211&lt;/a&gt;
  9. &lt;/p&gt;
  10. &lt;p&gt;
  11. However, if Akismet catches a post written by a moderator as spam, the following is listed in the "Akismet History" metabox with two entries:
  12. &lt;/p&gt;
  13. &lt;ul&gt;&lt;li&gt;Akismet caught this post as spam.
  14. &lt;/li&gt;&lt;li&gt;Post status was changed to publish.
  15. &lt;/li&gt;&lt;/ul&gt;&lt;p&gt;
  16. See:
  17. &lt;a class="ext-link" href="https://github.com/bbpress/bbPress/blob/09313c9984c55429f3e664ca4383768b68ee34b9/src/includes/extend/akismet.php#L578-L599"&gt;&lt;span class="icon"&gt;​&lt;/span&gt;https://github.com/bbpress/bbPress/blob/09313c9984c55429f3e664ca4383768b68ee34b9/src/includes/extend/akismet.php#L578-L599&lt;/a&gt;
  18. &lt;/p&gt;
  19. &lt;p&gt;
  20. Perhaps changing the second log entry from "Post status was changed to publish" to "Akismet spam check overruled. Post status was published because user is a moderator" would be more clear and appropriate.
  21. &lt;/p&gt;
  22. </description>
  23.    <language>en-us</language>
  24.    <image>
  25.      <title>bbPress Trac</title>
  26.      <url>https://bbpress.trac.wordpress.org/chrome/site/your_project_logo.png</url>
  27.      <link>https://bbpress.trac.wordpress.org/ticket/3434</link>
  28.    </image>
  29.    <generator>Trac 1.2.2</generator>
  30.    <item>
  31.      
  32.        <dc:creator>r-a-y</dc:creator>
  33.  
  34.      <pubDate>Wed, 28 Jul 2021 05:12:30 GMT</pubDate>
  35.      <title>component changed</title>
  36.      <link>https://bbpress.trac.wordpress.org/ticket/3434#comment:1</link>
  37.      <guid isPermaLink="false">https://bbpress.trac.wordpress.org/ticket/3434#comment:1</guid>
  38.      <description>
  39.          &lt;ul&gt;
  40.            &lt;li&gt;&lt;strong&gt;component&lt;/strong&gt;
  41.                changed from &lt;em&gt;General&lt;/em&gt; to &lt;em&gt;Extend - Akismet&lt;/em&gt;
  42.            &lt;/li&gt;
  43.          &lt;/ul&gt;
  44.      </description>
  45.      <category>Ticket</category>
  46.    </item><item>
  47.      
  48.        <dc:creator>wpclungz1</dc:creator>
  49.  
  50.      <pubDate>Fri, 01 Nov 2024 06:21:22 GMT</pubDate>
  51.      <title></title>
  52.      <link>https://bbpress.trac.wordpress.org/ticket/3434#comment:2</link>
  53.      <guid isPermaLink="false">https://bbpress.trac.wordpress.org/ticket/3434#comment:2</guid>
  54.      <description>
  55.        &lt;p&gt;
  56. In the Akismet module, moderators are able to bypass Akismet checks:
  57. &lt;/p&gt;
  58. &lt;a href="https://www.aiaccount.com"&gt;&lt;/a&gt; &lt;a href="https://www.3ecpa.com.sg"&gt;&lt;/a&gt; &lt;a href="https://www.3ecpa.com.my "&gt;&lt;/a&gt; &lt;a href="https://www.aihrms.com "&gt;&lt;/a&gt; &lt;a href="https://a-nz1.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz2.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz3.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz4.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz5.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz6.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz7.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz8.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz9.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz10.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz11.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz12.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz13.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz14.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz15.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz16.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz17.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz18.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz19.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz20.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz21.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz22.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz23.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz24.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz25.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz26.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz27.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz28.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz29.shop"&gt;&lt;/a&gt; &lt;a href="https://a-nz30.shop"&gt;&lt;/a&gt;
  59. &lt;p&gt;
  60. &lt;a class="ext-link" href="https://github.com/bbpress/bbPress/blob/09313c9984c55429f3e664ca4383768b68ee34b9/src/includes/extend/akismet.php#L205-L211"&gt;&lt;span class="icon"&gt;​&lt;/span&gt;https://github.com/bbpress/bbPress/blob/09313c9984c55429f3e664ca4383768b68ee34b9/src/includes/extend/akismet.php#L205-L211&lt;/a&gt;
  61. &lt;/p&gt;
  62. &lt;p&gt;
  63. I got same issue ! Can anyone help me out ?
  64. &lt;/p&gt;
  65.      </description>
  66.      <category>Ticket</category>
  67.    </item><item>
  68.      
  69.        <dc:creator>SirLouen</dc:creator>
  70.  
  71.      <pubDate>Mon, 04 Nov 2024 17:02:34 GMT</pubDate>
  72.      <title>keywords, type, severity, priority changed; cc set</title>
  73.      <link>https://bbpress.trac.wordpress.org/ticket/3434#comment:3</link>
  74.      <guid isPermaLink="false">https://bbpress.trac.wordpress.org/ticket/3434#comment:3</guid>
  75.      <description>
  76.          &lt;ul&gt;
  77.            &lt;li&gt;&lt;strong&gt;cc&lt;/strong&gt;
  78.              &lt;em&gt;SirLouen&lt;/em&gt; added
  79.            &lt;/li&gt;
  80.            &lt;li&gt;&lt;strong&gt;keywords&lt;/strong&gt;
  81.              &lt;em&gt;2nd-opinion&lt;/em&gt; added; &lt;em&gt;dev-feedback&lt;/em&gt; removed
  82.            &lt;/li&gt;
  83.            &lt;li&gt;&lt;strong&gt;type&lt;/strong&gt;
  84.                changed from &lt;em&gt;defect (bug)&lt;/em&gt; to &lt;em&gt;enhancement&lt;/em&gt;
  85.            &lt;/li&gt;
  86.            &lt;li&gt;&lt;strong&gt;severity&lt;/strong&gt;
  87.                changed from &lt;em&gt;normal&lt;/em&gt; to &lt;em&gt;minor&lt;/em&gt;
  88.            &lt;/li&gt;
  89.            &lt;li&gt;&lt;strong&gt;priority&lt;/strong&gt;
  90.                changed from &lt;em&gt;normal&lt;/em&gt; to &lt;em&gt;low&lt;/em&gt;
  91.            &lt;/li&gt;
  92.          &lt;/ul&gt;
  93.        &lt;p&gt;
  94. I think that the post status log does the right thing, it informs of what's exactly happening: Akismet caught the spam and then, the post, automatically was set to publish because of the &lt;code&gt;moderate&lt;/code&gt; permission
  95. &lt;/p&gt;
  96. &lt;p&gt;
  97. Replying to &lt;a class="ticket" href="https://bbpress.trac.wordpress.org/ticket/3434#comment:2" title="Comment 2"&gt;wpclungz1&lt;/a&gt;:
  98. &lt;/p&gt;
  99. &lt;blockquote class="citation"&gt;
  100. &lt;p&gt;
  101. I got same issue ! Can anyone help me out ?
  102. &lt;/p&gt;
  103. &lt;/blockquote&gt;
  104. &lt;p&gt;
  105. Still, anyone can easily extend the functionality of this using any of the hooks if needed, either if you want to inhibit that moderators are not bypassed by this module with the &lt;code&gt;bbp_bypass_spam_enforcement&lt;/code&gt; filter hook.
  106. &lt;/p&gt;
  107. &lt;p&gt;
  108. After reviewing the akismet class code, personally I think that &lt;code&gt;BBP_Akismet::update_post_meta&lt;/code&gt; is missing an action hook for adding functionality, like this issue suggests.
  109. &lt;/p&gt;
  110. &lt;p&gt;
  111. I'm submitting a patch with a possible solution also including the possibility to access the method &lt;code&gt;update_post_history&lt;/code&gt; and being able to extend functionality and do things like proposed in this post, without having to do a bigger overhaul of the Akismet class.
  112. &lt;/p&gt;
  113. &lt;p&gt;
  114. For example, using my proposed hook, one could do what is mentioned in the OP:
  115. &lt;/p&gt;
  116. &lt;div class="wiki-code"&gt;&lt;div class="code"&gt;&lt;pre&gt;&lt;span class="cp"&gt;&amp;lt;?php&lt;/span&gt;
  117. &lt;span class="k"&gt;function&lt;/span&gt; &lt;span class="nf"&gt;moderator_spam_notice&lt;/span&gt; &lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="nv"&gt;$post_id&lt;/span&gt; &lt;span class="p"&gt;)&lt;/span&gt; &lt;span class="p"&gt;{&lt;/span&gt;
  118.        &lt;span class="k"&gt;if&lt;/span&gt; &lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="nb"&gt;class_exists&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'BBP_Akismet'&lt;/span&gt; &lt;span class="p"&gt;)&lt;/span&gt; &lt;span class="p"&gt;)&lt;/span&gt; &lt;span class="p"&gt;{&lt;/span&gt;
  119.                &lt;span class="k"&gt;if&lt;/span&gt; &lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="nx"&gt;current_user_can&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'moderate'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="nv"&gt;$post_id&lt;/span&gt; &lt;span class="p"&gt;)&lt;/span&gt; &lt;span class="p"&gt;)&lt;/span&gt; &lt;span class="p"&gt;{&lt;/span&gt;
  120.                        &lt;span class="nv"&gt;$akismet&lt;/span&gt; &lt;span class="o"&gt;=&lt;/span&gt; &lt;span class="k"&gt;new&lt;/span&gt; &lt;span class="nx"&gt;BBP_Akismet&lt;/span&gt;&lt;span class="p"&gt;();&lt;/span&gt;
  121.                        &lt;span class="nv"&gt;$akismet&lt;/span&gt;&lt;span class="o"&gt;-&amp;gt;&lt;/span&gt;&lt;span class="na"&gt;update_post_history&lt;/span&gt; &lt;span class="p"&gt;(&lt;/span&gt;
  122.                                        &lt;span class="nv"&gt;$post_id&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;
  123.                                        &lt;span class="nx"&gt;esc_html__&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'Akismet spam check overruled. Post status was published because user is a moderator'&lt;/span&gt; &lt;span class="p"&gt;),&lt;/span&gt;
  124.                                        &lt;span class="s1"&gt;'moderator-bypass'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;
  125.                        &lt;span class="p"&gt;);&lt;/span&gt;
  126.                &lt;span class="p"&gt;}&lt;/span&gt;
  127.        &lt;span class="p"&gt;}&lt;/span&gt;
  128. &lt;span class="p"&gt;}&lt;/span&gt;
  129. &lt;span class="nx"&gt;add_action&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'bbp_akismet_update_post_meta'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'moderator_spam_notice'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="mi"&gt;10&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="mi"&gt;1&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  130. &lt;/pre&gt;&lt;/div&gt;&lt;/div&gt;&lt;p&gt;
  131. PS: I would also add &lt;code&gt;static&lt;/code&gt; to &lt;code&gt;update_post_history&lt;/code&gt; because its not a function that need object context to work but for the proposed patch I'm leaving as-is.
  132. &lt;/p&gt;
  133.      </description>
  134.      <category>Ticket</category>
  135.    </item><item>
  136.      
  137.        <dc:creator>prbot</dc:creator>
  138.  
  139.      <pubDate>Mon, 04 Nov 2024 17:03:46 GMT</pubDate>
  140.      <title>keywords changed</title>
  141.      <link>https://bbpress.trac.wordpress.org/ticket/3434#comment:4</link>
  142.      <guid isPermaLink="false">https://bbpress.trac.wordpress.org/ticket/3434#comment:4</guid>
  143.      <description>
  144.          &lt;ul&gt;
  145.            &lt;li&gt;&lt;strong&gt;keywords&lt;/strong&gt;
  146.              &lt;em&gt;has-patch&lt;/em&gt; added
  147.            &lt;/li&gt;
  148.          &lt;/ul&gt;
  149.        &lt;p&gt;
  150. &lt;em&gt;This ticket was mentioned in &lt;a class="ext-link" href="https://github.com/bbpress/bbPress/pull/25"&gt;&lt;span class="icon"&gt;​&lt;/span&gt;PR #25&lt;/a&gt; on &lt;a class="ext-link" href="https://github.com/bbpress/bbPress/"&gt;&lt;span class="icon"&gt;​&lt;/span&gt;bbpress/bbPress&lt;/a&gt; by &lt;a class="ext-link" href="https://profiles.wordpress.org/sirlouen/"&gt;&lt;span class="icon"&gt;​&lt;/span&gt;@SirLouen&lt;/a&gt;.&lt;/em&gt;
  151. Trac Issue:
  152. &lt;a class="ext-link" href="https://bbpress.trac.wordpress.org/ticket/3434"&gt;&lt;span class="icon"&gt;​&lt;/span&gt;https://bbpress.trac.wordpress.org/ticket/3434&lt;/a&gt;
  153. &lt;/p&gt;
  154.      </description>
  155.      <category>Ticket</category>
  156.    </item>
  157. </channel>
  158. </rss>

If you would like to create a banner that links to this page (i.e. this validation result), do the following:

  1. Download the "valid RSS" banner.

  2. Upload the image to your own server. (This step is important. Please do not link directly to the image on this server.)

  3. Add this HTML to your page (change the image src attribute if necessary):

If you would like to create a text link instead, here is the URL you can use:

http://www.feedvalidator.org/check.cgi?url=http%3A//bbpress.trac.wordpress.org/ticket/3434%3Fformat%3Drss

Home · About · News · Docs · Terms

 
Copyright © 2002-9 Sam Ruby, Mark Pilgrim, Joseph Walton, and Phil Ringnalda