<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"><html xmlns="http://www.w3.org/1999/xhtml"> <head> <title> #2322 (Moving Topic doesn't update _bbp_topic_count) – bbPress Trac </title> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> <meta http-equiv="X-UA-Compatible" content="IE=edge" /> <!--[if IE]><script type="text/javascript"> if (/^#__msie303:/.test(window.location.hash)) window.location.replace(window.location.hash.replace(/^#__msie303:/, '#')); </script><![endif]--> <link rel="search" href="/search" /> <link rel="prev" href="/ticket/2321" title="Ticket #2321" /> <link rel="last" href="/ticket/3609" title="Ticket #3609" /> <link rel="help" href="/wiki/TracGuide" /> <link rel="alternate" href="/ticket/2322?format=csv" type="text/csv" class="csv" title="Comma-delimited Text" /> <link rel="alternate" href="/ticket/2322?format=tab" type="text/tab-separated-values" class="tab" title="Tab-delimited Text" /> <link rel="alternate" href="/ticket/2322?format=rss" type="application/rss+xml" class="rss" title="RSS Feed" /> <link rel="next" href="/ticket/2323" title="Ticket #2323" /> <link rel="start" href="/wiki" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/trac.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/ticket.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/jquery-ui/jquery-ui.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/jquery-ui-addons.css?v=220" /> <link rel="icon" href="https://bbpress.org/favicon.ico" type="image/x-icon" /> <link rel="first" href="/ticket/1" title="Ticket #1" /> <style id="trac-noscript" type="text/css">.trac-noscript { display: none !important }</style> <link type="application/opensearchdescription+xml" rel="search" href="/search/opensearch" title="Search bbPress Trac" /> <script type="text/javascript"> var auto_preview_timeout=2.0; var form_token="06e1946b785923f2373286a6"; var jquery_ui={"ampm":true,"date_format":"mm/dd/yy","day_names":{"abbreviated":["Sun","Mon","Tue","Wed","Thu","Fri","Sat"],"narrow":["Su","Mo","Tu","We","Th","Fr","Sa"],"wide":["Sunday","Monday","Tuesday","Wednesday","Thursday","Friday","Saturday"]},"default_timezone":null,"first_week_day":0,"month_names":{"abbreviated":["Jan","Feb","Mar","Apr","May","Jun","Jul","Aug","Sep","Oct","Nov","Dec"],"wide":["January","February","March","April","May","June","July","August","September","October","November","December"]},"period_names":{"am":["AM","AM"],"pm":["PM","PM"]},"show_timezone":false,"time_format":"hh:mm:ss TT","timepicker_separator":" ","timezone_iso8601":false,"timezone_list":null}; var comments_prefs={"comments_order":"oldest","show_comments":"true","show_prop_changes":"true"}; </script> <link rel="dns-prefetch" href="//fonts.googleapis.com" /> <link rel="dns-prefetch" href="//www.googletagmanager.com" /> <script>//<![CDATA[ (function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start': new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0], j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src= 'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); })(window,document,'script','dataLayer','GTM-P24PF4B'); //]]></script> <link rel="stylesheet" href="//fonts.googleapis.com/css?family=Open+Sans%3A300italic%2C400italic%2C600italic%2C300%2C400%2C600&subset=latin%2Clatin-ext&ver=3.8.1-alpha" type="text/css" media="all" /> <link type="text/css" media="screen" rel="stylesheet" href="//bbpress.org/wp-content/themes/bb-base/style.css?v=24" /> <link type="text/css" media="screen" rel="stylesheet" href="//bbpress.org/wp-content/themes/bb-base/style-bbpress.css?v=24" /> <meta name="viewport" content="width=device-width" /> <link rel="stylesheet" href="https://s.w.org/wp-includes/css/dashicons.min.css?20150710" type="text/css" /> <link rel="stylesheet" type="text/css" href="https://s.w.org/style/trac/wp-trac.css?220" /> <script src="https://s.w.org/style/trac/common/js/jquery.js?v=220"></script> <link rel="canonical" href="https://bbpress.trac.wordpress.org/ticket/2322" /> <script src="https://s.w.org/style/trac/common/js/babel.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/trac.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/search.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/folding.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/wikitoolbar.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/resizer.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/auto_preview.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui-addons.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui-i18n.js?v=220"></script> <script type="text/javascript"> jQuery("#trac-noscript").remove(); jQuery(document).ready(function($) { $(".trac-autofocus").focus(); $(".trac-target-new").attr("target", "_blank"); if ($.ui) { /* is jquery-ui added? */ $(".trac-datepicker:not([readonly])").prop("autocomplete", "off").datepicker(); $(".trac-datetimepicker:not([readonly])").prop("autocomplete", "off").datetimepicker(); $("#main").addClass("trac-nodatetimehint"); } $(".trac-disable").disableSubmit(".trac-disable-determinant"); setTimeout(function() { $(".trac-scroll").scrollToTop() }, 1); $(".trac-disable-on-submit").disableOnSubmit(); }); </script> <script src="https://s.w.org/style/trac/common/js/threaded_comments.js?v=220"></script> <script type="text/javascript"> jQuery(document).ready(function($) { $("div.description").find("h1,h2,h3,h4,h5,h6").addAnchor(_("Link to this section")); $(".foldable").enableFolding(false, true); /*<![CDATA[*/ $("#attachments").toggleClass("collapsed"); $("#trac-up-attachments").click(function () { $("#attachments").removeClass("collapsed"); return true; }); $("#modify").parent().toggleClass("collapsed"); $(".trac-topnav a").click(function() { $("#modify").parent().removeClass("collapsed"); }); function setRevertHandler() { $("button.trac-revert").click(function() { var div = $("div", this); var field_name = div[0].id.substr(7); var field_value = div.text(); var input = $("#propertyform *[name=field_" + field_name + "]"); if (input.length > 0) { if (input.filter("input[type=radio]").length > 0) { input.val([field_value]); } else if (input.filter("input[type=checkbox]").length > 0) { input.val(field_value == "1" ? [field_value] : []); } else { input.val(field_value); } } else { // Special case for CC checkbox input = $("#propertyform input[name=cc_update]").val([]); } input.change(); // Remove the revert button if ($(this).closest("tbody").children("tr").length === 1) $(this).closest(".trac-change-panel").remove(); else $(this).closest("tr").remove(); return false; }); } setRevertHandler(); var comment_focused = false; $("#comment").focus(function() { comment_focused = true; }) .blur(function() { comment_focused = false; }); $("#propertyform").autoSubmit({preview: '1'}, function(data, reply) { var items = $(reply); // Update ticket box $("#ticket").replaceWith(items.filter('#ticket')); // Replaces content of #changelog, without recreating it $("#changelog").empty().append(items.filter("#changelog").contents()); // Apply comments order and "Show" preferences applyCommentsOrder( $('#prefs input[name="trac-comments-order"]:checked').val()); // Show warning var new_changes = $("#changelog .trac-new"); $("#trac-edit-warning").toggle(new_changes.length != 0); if (new_changes.length != 0) $("#changelog").parent().show().removeClass("collapsed"); // Update view time $("#propertyform input[name='view_time']").replaceWith(items.filter("input[name='view_time']")); // Update preview var preview = $("#ticketchange").html(items.filter('#preview').children()); var show_preview = preview.children().length != 0; $("#ticketchange").toggle(show_preview); setRevertHandler(); // Execute scripts to load stylesheets items.filter("script").appendTo("head"); }, "#ticketchange .trac-loading"); $("#trac-comment-editor").autoSubmit({preview_comment: '1'}, function(data, reply) { var comment = $("#trac-comment-editor").next("div.comment").html(reply); comment.toggle(comment.children().length != 0); }, "#changelog .trac-loading"); /*]]>*/ }); </script> </head> <body id="wordpress-org" class="bbpress trac wporg-make make-bbpress"> <noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-P24PF4B" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript> <dl id="accessibility"> <dt>Skip to:</dt> <dd><a href="#content" title="Skip to content">Content</a></dd> </dl> <div id="wporg-header"> <div id="header-inner"> <button id="mobile-menu-button" aria-expanded="false"><span class="screen-reader-text">Toggle Menu</span></button> <ul id="wporg-header-menu"> <li><a href="https://bbpress.org/about/">About</a></li> <li><a href="https://bbpress.org/plugins/">Plugins</a></li> <li><a href="https://bbpress.org/themes/">Themes</a></li> <li><a href="https://codex.bbpress.org/">Documentation</a></li> <li><a href="https://bbpress.org/blog/">Blog</a></li> <li><a href="https://bbpress.org/forums/">Support</a></li> <li class="download"><a href="https://bbpress.org/download/">Download</a></li> </ul> <h1><a href="https://bbpress.org">bbPress.org</a></h1> </div> </div> <div id="subnav"> <div id="subnav-inner"> <ul id="nav-user" class="menu"> <li class="last first"> <a href="https://login.wordpress.org/?redirect_to=https%3A%2F%2Fbbpress.trac.wordpress.org%2Fticket%2F2322" class="login">Login</a></li> </ul> </div> </div> <div id="banner"> <form id="search" action="/search" method="get"> <div> <label for="proj-search">Search:</label> <input type="text" id="proj-search" name="q" size="18" value="" /> <input type="submit" value="Search" /> </div> </form> </div> <div id="mainnav" class="nav"> <ul> <li class="first"><a href="/timeline">Timeline</a></li><li class="active"><a href="/report">View Tickets</a></li><li><a href="/roadmap">Roadmap</a></li><li><a href="/browser">Browse Source</a></li><li class="last"><a href="/ticketgraph">Ticket Graph</a></li> </ul> </div> <div id="main"> <div id="ctxtnav" class="nav"> <h2>Context Navigation</h2> <ul> <li class="first"><span>← <a class="prev" href="/ticket/2321" title="Ticket #2321">Previous Ticket</a></span></li><li class="last"><span><a class="next" href="/ticket/2323" title="Ticket #2323">Next Ticket</a> →</span></li> </ul> <hr /> </div> <div id="content" class="ticket"> <div id="ticket" class="trac-content "> <div class="date"> <p>Opened <a class="timeline" href="/timeline?from=2013-05-02T08%3A14%3A31Z&precision=second" title="See timeline at 05/02/2013 08:14:31 AM">12 years ago</a></p> <p>Closed <a class="timeline" href="/timeline?from=2015-05-12T19%3A35%3A02Z&precision=second" title="See timeline at 05/12/2015 07:35:02 PM">9 years ago</a></p> <p>Last modified <a class="timeline" href="/timeline?from=2015-05-22T08%3A30%3A09Z&precision=second" title="See timeline at 05/22/2015 08:30:09 AM">9 years ago</a></p> </div> <h2> <a href="/ticket/2322" class="trac-id">#2322</a> <span class="trac-status"> <a href="/query?status=closed">closed</a> </span> <span class="trac-type"> <a href="/query?status=!closed&type=defect+(bug)">defect (bug)</a> </span> <span class="trac-resolution"> (<a href="/query?status=closed&resolution=fixed">fixed</a>) </span> </h2> <h1 id="trac-ticket-title" class="searchable"> <span class="summary">Moving Topic doesn't update _bbp_topic_count</span> </h1> <table class="properties"> <tr> <th id="h_reporter">Reported by:</th> <td headers="h_reporter" class="searchable"> <a href="https://profiles.wordpress.org/wpdennis" data-nicename="wpdennis"> <img class="avatar" src="https://wordpress.org/grav-redirect.php?user=wpdennis&s=48" srcset="https://wordpress.org/grav-redirect.php?user=wpdennis&s=96 2x" height="48" width="48" alt="wpdennis's profile" /> </a> <a class="trac-author" href="/query?status=!closed&reporter=wpdennis">wpdennis</a></td> <th id="h_owner">Owned by:</th> <td headers="h_owner"> <a href="https://profiles.wordpress.org/johnjamesjacoby"> <img class="avatar" src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="johnjamesjacoby's profile" /> </a> <a class="trac-author" href="/query?status=!closed&owner=johnjamesjacoby">johnjamesjacoby</a></td> </tr> <tr> <th id="h_milestone"> Milestone: </th> <td headers="h_milestone"> <a class="closed milestone" href="/milestone/2.6" title="Completed 5 years ago (11/12/2019 05:00:00 PM)">2.6</a> </td> <th id="h_priority"> Priority: </th> <td headers="h_priority"> <a href="/query?status=!closed&priority=high">high</a> </td> </tr><tr> <th id="h_severity"> Severity: </th> <td headers="h_severity"> <a href="/query?status=!closed&severity=normal">normal</a> </td> <th id="h_version"> Version: </th> <td headers="h_version"> <a href="/query?status=!closed&version=2.3">2.3</a> </td> </tr><tr> <th id="h_component"> Component: </th> <td headers="h_component"> <a href="/query?status=!closed&component=Component+-+Forums">Component - Forums</a> </td> <th id="h_keywords"> Keywords: </th> <td headers="h_keywords" class="searchable"> <a href="/query?status=!closed&keywords=~has-patch">has-patch</a> </td> </tr><tr> <th id="h_cc" class="missing"> Cc: </th> <td headers="h_cc" class="searchable"> </td> <th class="missing"> </th> <td> </td> </tr> </table> <div class="description"> <h3 id="comment:description"> Description </h3> <div class="searchable"> <p>If I move topics in the front-end it doesn't update the postmetas "_bbp_topic_count", "_bbp_reply_count", "_bbp_total_reply_count" and "_bbp_total_topic_count" neither of the target nor the old forum post. <br /></p><p>bbp_move_topic_handler() calls bbp_update_topic_forum_id() and maybe bbp_update_topic_forum_id() could recalc the counts of the old and the new forum post?<br /></p> </div> </div></div> <div id="attachments"> <h3 class="foldable">Attachments <span class="trac-count">(1)</span></h3> <div class="attachments"> <dl class="attachments"> <dt> <a href="/attachment/ticket/2322/2322.01.patch" title="View attachment">2322.01.patch</a><a href="/raw-attachment/ticket/2322/2322.01.patch" class="trac-rawlink" title="Download"></a> (<span title="562 bytes">562 bytes</span>) - added by <span class="trac-author">thebrandonallen</span> <a class="timeline" href="/timeline?from=2015-05-12T06%3A20%3A12Z&precision=second" title="See timeline at 05/12/2015 06:20:12 AM">9 years ago</a>. </dt> </dl> <p> Download all attachments as: <a rel="nofollow" href="/zip-attachment/ticket/2322/">.zip</a> </p> </div> </div> <div> <div class="trac-noscript" style="position: relative"> <form id="prefs" method="get" action="/prefs" style="position: absolute; right: 0"> <div id="trac-comments-order"> <input type="radio" id="trac-comments-oldest" name="trac-comments-order" value="oldest" checked="checked" /> <label for="trac-comments-oldest">Oldest first</label> <input type="radio" id="trac-comments-newest" name="trac-comments-order" value="newest" /> <label for="trac-comments-newest">Newest first</label> <span id="trac-threaded-toggle" style="display: none"> <input type="radio" id="trac-comments-threaded" name="trac-comments-order" value="threaded" /> <label for="trac-comments-threaded">Threaded</label> </span> </div> <div> <input id="trac-show-comments-toggle" type="checkbox" checked="checked" /> <label for="trac-show-comments-toggle">Show comments</label> <input id="trac-show-property-changes-toggle" type="checkbox" /> <label for="trac-show-property-changes-toggle">Show property changes</label> </div> </form> </div> <h3 class="foldable">Change History <span class="trac-count">(17)</span></h3> <div id="changelog"> <div class="change" id="trac-change-1-1367597793992206"> <h3 class="change"> <span class="threading"> <span id="comment:1" class="cnum"> <a href="#comment:1">#1</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-05-03T16%3A16%3A33Z&precision=second" title="See timeline at 05/03/2013 04:16:33 PM">12 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-keywords"> <strong class="trac-field-keywords">Keywords</strong> <em>needs-patch</em> added </li><li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> changed from <em>Awaiting Review</em> to <em>2.4</em> </li> </ul> <div class="comment searchable"> <p>Hm. Thought we'd fixed this once before. Moving to 2.4 to look into this there.<br /></p> </div> </div> <div class="change" id="trac-change-2-1372044972693387"> <h3 class="change"> <span class="threading"> <span id="comment:2" class="cnum"> <a href="#comment:2">#2</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/aliso" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=aliso&s=48" srcset="https://wordpress.org/grav-redirect.php?user=aliso&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="aliso" data-nicename="aliso"><span class="trac-author">aliso</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-06-24T03%3A36%3A12Z&precision=second" title="See timeline at 06/24/2013 03:36:12 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> <em>2.4</em> deleted </li><li class="trac-field-resolution"> <strong class="trac-field-resolution">Resolution</strong> set to <em>worksforme</em> </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>new</em> to <em>closed</em> </li> </ul> <div class="comment searchable"> <p>I'm not able to reproduce this - all the meta values are updating properly for me when I move a topic from one forum to another. Closing for now.<br /></p> </div> </div> <div class="change" id="trac-change-3-1372095517541495"> <h3 class="change"> <span class="threading"> <span id="comment:3" class="cnum"> <a href="#comment:3">#3</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/alexvorn2" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=alexvorn2&s=48" srcset="https://wordpress.org/grav-redirect.php?user=alexvorn2&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="alexvorn2" data-nicename="alexvorn2"><span class="trac-author">alexvorn2</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-06-24T17%3A38%3A37Z&precision=second" title="See timeline at 06/24/2013 05:38:37 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>related <a class="new ticket" href="/ticket/1981" title="#1981: defect (bug): Update topic/replies count after subforums changed location (new)">#1981</a><br /></p> </div> </div> <div class="change" id="trac-change-4-1384722332561700"> <h3 class="change"> <span class="threading"> <span id="comment:4" class="cnum"> <a href="#comment:4">#4</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/wpdennis" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=wpdennis&s=48" srcset="https://wordpress.org/grav-redirect.php?user=wpdennis&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="wpdennis" data-nicename="wpdennis"><span class="trac-author">wpdennis</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-17T21%3A05%3A32Z&precision=second" title="See timeline at 11/17/2013 09:05:32 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-resolution"> <strong class="trac-field-resolution">Resolution</strong> <em>worksforme</em> deleted </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>closed</em> to <em>reopened</em> </li> </ul> <div class="comment searchable"> <p>It's not fixed. Not even in 2.4.1.<br /></p><p>I've done some more digging. To reproduce it you need to activate object caching.<br /></p><p>The reason seems to be that <a class="ext-link" href="http://bbpress.trac.wordpress.org/browser/tags/2.4.1/includes/common/functions.php#L1335"><span class="icon"></span>bbp_get_public_child_ids</a> gets the topics to count from the object cache:<br /></p><pre class="wiki">// Check for cache and set if needed$child_ids = wp_cache_get( $cache_id, 'bbpress_posts' );</pre><p>But during the topic moving the cache wasn't invalidated and will not contain the moved topic.<br /></p><p>The cache will only be invalidated in <em>bbp_clean_post_cache()</em>, but this is not added to <em>bbp_edit_forum_pre_extras</em> (and we shouldn't do that, it would be too expensive). <br /></p><p>It is only added to <em>bbp_new_forum_pre_extras</em> and similar actions.<br /></p><p>Maybe we could add a new action in the beginning of <em>bbp_move_topic_handler()</em> and add <em>bbp_clean_post_cache()</em> to it?<br /></p><p>Like <em>bbp_move_forum_pre_extras</em> or something?<br /></p> </div> </div> <div class="change" id="trac-change-5-1384723246559889"> <h3 class="change"> <span class="threading"> <span id="comment:5" class="cnum"> <a href="#comment:5">#5</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/wpdennis" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=wpdennis&s=48" srcset="https://wordpress.org/grav-redirect.php?user=wpdennis&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="wpdennis" data-nicename="wpdennis"><span class="trac-author">wpdennis</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-17T21%3A20%3A46Z&precision=second" title="See timeline at 11/17/2013 09:20:46 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>The idea with <em>bbp_move_forum_pre_extras</em> wasn't that good, since we need it for every forum.<br /></p><p>As a hack, adding <em>bbp_clean_post_cache( $ancestor );</em> in <a class="ext-link" href="http://bbpress.trac.wordpress.org/browser/tags/2.4.1/includes/topics/functions.php#L997"><span class="icon"></span>bbp_move_topic_handler()</a> is working:<br /></p><pre class="wiki">// Loop through ancestors and update themif ( !empty( $old_forum_ancestors ) ) { foreach ( $old_forum_ancestors as $ancestor ) { if ( bbp_is_forum( $ancestor ) ) { bbp_clean_post_cache( $ancestor ); bbp_update_forum( array( 'forum_id' => $ancestor, ) ); } }}</pre><p>and:<br /></p><pre class="wiki">// Loop through ancestors and update themif ( !empty( $new_forum_ancestors ) ) { foreach ( $new_forum_ancestors as $ancestor ) { if ( bbp_is_forum( $ancestor ) ) { bbp_clean_post_cache( $ancestor ); bbp_update_forum( array( 'forum_id' => $ancestor, ) ); } }}</pre> </div> </div> <div class="change" id="trac-change-6-1384730311924910"> <h3 class="change"> <span class="threading"> <span id="comment:6" class="cnum"> <a href="#comment:6">#6</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-17T23%3A18%3A31Z&precision=second" title="See timeline at 11/17/2013 11:18:31 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> set to <em>Awaiting Review</em> </li> </ul> </div> <div class="change" id="trac-change-7-1384772694263985"> <h3 class="change"> <span class="threading"> <span id="comment:7" class="cnum"> <a href="#comment:7">#7</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-18T11%3A04%3A54Z&precision=second" title="See timeline at 11/18/2013 11:04:54 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>What if we clean the post cache when updating a forum? We should be doing that anyways; is that enough, VS the brute force tree flush?<br /></p> </div> </div> <div class="change" id="trac-change-8-1384774312790740"> <h3 class="change"> <span class="threading"> <span id="comment:8" class="cnum"> <a href="#comment:8">#8</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/wpdennis" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=wpdennis&s=48" srcset="https://wordpress.org/grav-redirect.php?user=wpdennis&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="wpdennis" data-nicename="wpdennis"><span class="trac-author">wpdennis</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-18T11%3A31%3A52Z&precision=second" title="See timeline at 11/18/2013 11:31:52 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>You mean in <em>bbp_update_forum()</em>? That would do the trick.<br /></p><p><em>bbp_update_topic_walker()</em> would call it, too. But in <em>bbp_update_topic()</em> it only gets triggered on new topics, is it?<br /></p><p>Just a quick note aside:<br />On new topics and probably some other things it would get called twice. If it's expensive, maybe <a class="ext-link" href="http://bbpress.trac.wordpress.org/browser/tags/2.4.1/includes/core/actions.php#L258"><span class="icon"></span>these actions</a> should be revisited:<br /></p><pre class="wiki">// Cachesadd_action( 'bbp_new_forum_pre_extras', 'bbp_clean_post_cache' );add_action( 'bbp_new_forum_post_extras', 'bbp_clean_post_cache' );add_action( 'bbp_new_topic_pre_extras', 'bbp_clean_post_cache' );add_action( 'bbp_new_topic_post_extras', 'bbp_clean_post_cache' );add_action( 'bbp_new_reply_pre_extras', 'bbp_clean_post_cache' );add_action( 'bbp_new_reply_post_extras', 'bbp_clean_post_cache' );</pre> </div> </div> <div class="change" id="trac-change-9-1384779466802720"> <h3 class="change"> <span class="threading"> <span id="comment:9" class="cnum"> <a href="#comment:9">#9</a> </span> <span>follow-up:</span> <a href="#comment:10" class="follow-up">↓ 10</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-18T12%3A57%3A46Z&precision=second" title="See timeline at 11/18/2013 12:57:46 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Not very expensive, but it's not currently ideal. You're correct that we should revisit our cache (and cache busting) strategy to make sure we're not running into more situations like this one. This will become more and more important as we stop doing expensive recalculations and start incrementing based on existing values.<br /></p><p>There is a lot we can learn from <a class="wiki" href="/wiki/WordPress">WordPress</a> core and Pages in this regard.<br /></p> </div> </div> <div class="change" id="trac-change-10-1385206834993280"> <h3 class="change"> <span class="threading"> <span id="comment:10" class="cnum"> <a href="#comment:10">#10</a> </span> in reply to: <a href="#comment:9">↑ 9</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/wpdennis" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=wpdennis&s=48" srcset="https://wordpress.org/grav-redirect.php?user=wpdennis&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="wpdennis" data-nicename="wpdennis"><span class="trac-author">wpdennis</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-23T11%3A40%3A34Z&precision=second" title="See timeline at 11/23/2013 11:40:34 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Maybe we should split this ticket then. <br /></p><p>We could use this for Ticket for the Hotfix you suggested. <br /></p><p>It's so much work to fix the counts manually in a live system with object caching enabled, that maybe you could consider to add the cache cleaning in 2.4.2 as a temporary fix? I'm currently testing it and will report back soon.<br /></p><p>For the more ideal solution a new ticket would be better, especially if it's targeting the whole caching strategy. But I'm sorry, I haven't enough insights to start this ticket myself.<br /></p> </div> </div> <div class="change" id="trac-change-11-1385484462889838"> <h3 class="change"> <span class="threading"> <span id="comment:11" class="cnum"> <a href="#comment:11">#11</a> </span> <span>follow-up:</span> <a href="#comment:12" class="follow-up">↓ 12</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-26T16%3A47%3A42Z&precision=second" title="See timeline at 11/26/2013 04:47:42 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> changed from <em>Awaiting Review</em> to <em>2.6</em> </li> </ul> <div class="comment searchable"> <p>We should be busting the cache for every change made to any post type or their meta. It's somewhat expensive given the hierarchical nature of reply > topic > forum(s), but it's necessary to make sure we're getting the correct results. This will become even more important when we move to _bump_ functions rather than recalculations, as we'll want to make sure we're getting the correct counts from fresh post data to bump from.<br /></p><p>How's your test run looking?<br /></p> </div> </div> <div class="change" id="trac-change-12-1385547404704422"> <h3 class="change"> <span class="threading"> <span id="comment:12" class="cnum"> <a href="#comment:12">#12</a> </span> in reply to: <a href="#comment:11">↑ 11</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/wpdennis" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=wpdennis&s=48" srcset="https://wordpress.org/grav-redirect.php?user=wpdennis&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="wpdennis" data-nicename="wpdennis"><span class="trac-author">wpdennis</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-27T10%3A16%3A44Z&precision=second" title="See timeline at 11/27/2013 10:16:44 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <blockquote class="citation"><p>We should be busting the cache for every change made to any post type or their meta. It's somewhat expensive given the hierarchical nature of reply > topic > forum(s), but it's necessary to make sure we're getting the correct results.<br /></p></blockquote><p>Yes, editing existing posts doesn't need to recalculate counts but shouldn't be worth the trouble, to build extra work arounds. <br /></p><p>Editing is a relativly rare scenario and avoiding caching issues should be more important. So, cleaning the chache for every change should be the safest way.<br /></p><blockquote class="citation"><p>How's your test run looking?<br /></p></blockquote><p>The specific bug (moving multiple topics into a newly created forum) is gone. Even programmatically created posts seem to work better now (I just noticed another caching bug in this case a few days ago).<br /></p><p>I've patched it in a live environment 2 days ago, too. No errors or other bad things happened so far. :-)<br /></p><p>This is the function with the added <em>bbp_clean_post_cache()</em>:<br /></p><pre class="wiki">function bbp_update_forum( $args = '' ) { // Parse arguments against default values $r = bbp_parse_args( $args, array( 'forum_id' => 0, 'post_parent' => 0, 'last_topic_id' => 0, 'last_reply_id' => 0, 'last_active_id' => 0, 'last_active_time' => 0, 'last_active_status' => bbp_get_public_status_id() ), 'update_forum' ); // Last topic and reply ID's bbp_update_forum_last_topic_id( $r['forum_id'], $r['last_topic_id'] ); bbp_update_forum_last_reply_id( $r['forum_id'], $r['last_reply_id'] ); bbp_clean_post_cache( $r['forum_id'] ); // Active dance $r['last_active_id'] = bbp_update_forum_last_active_id( $r['forum_id'], $r['last_active_id'] ); // If no active time was passed, get it from the last_active_id if ( empty( $r['last_active_time'] ) ) { $r['last_active_time'] = get_post_field( 'post_date', $r['last_active_id'] ); } if ( bbp_get_public_status_id() === $r['last_active_status'] ) { bbp_update_forum_last_active_time( $r['forum_id'], $r['last_active_time'] ); } // Counts bbp_update_forum_subforum_count ( $r['forum_id'] ); bbp_update_forum_reply_count ( $r['forum_id'] ); bbp_update_forum_topic_count ( $r['forum_id'] ); bbp_update_forum_topic_count_hidden( $r['forum_id'] ); // Update the parent forum if one was passed if ( !empty( $r['post_parent'] ) && is_numeric( $r['post_parent'] ) ) { bbp_update_forum( array( 'forum_id' => $r['post_parent'], 'post_parent' => get_post_field( 'post_parent', $r['post_parent'] ) ) ); }}</pre> </div> </div> <div class="change" id="trac-change-13-1386196121656886"> <h3 class="change"> <span class="threading"> <span id="comment:13" class="cnum"> <a href="#comment:13">#13</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-12-04T22%3A28%3A41Z&precision=second" title="See timeline at 12/04/2013 10:28:41 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-owner"> <strong class="trac-field-owner">Owner</strong> set to <em>johnjamesjacoby</em> </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>reopened</em> to <em>new</em> </li> </ul> </div> <div class="change" id="trac-change-14-1431411582334319"> <h3 class="change"> <span class="threading"> <span id="comment:14" class="cnum"> <a href="#comment:14">#14</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/thebrandonallen" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=thebrandonallen&s=48" srcset="https://wordpress.org/grav-redirect.php?user=thebrandonallen&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="thebrandonallen" data-nicename="thebrandonallen"><span class="trac-author">thebrandonallen</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2015-05-12T06%3A19%3A42Z&precision=second" title="See timeline at 05/12/2015 06:19:42 AM">9 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-keywords"> <strong class="trac-field-keywords">Keywords</strong> <em>has-patch</em> added; <em>dev-feedback</em> <em>needs-patch</em> removed </li> </ul> <div class="comment searchable"> <p>Ran into this issue while working on tests for <a class="closed ticket" href="/ticket/2801" title="#2801: enhancement: Increased/improved count tests and the issues they uncovered (closed: fixed)">#2801</a>. Attached patch should be all that's needed.<br /></p> </div> </div> <div class="change"> <h3 class="change"> <span class="threading"> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/thebrandonallen" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=thebrandonallen&s=48" srcset="https://wordpress.org/grav-redirect.php?user=thebrandonallen&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="thebrandonallen" data-nicename="thebrandonallen"><span class="trac-author">thebrandonallen</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2015-05-12T06%3A20%3A12Z&precision=second" title="See timeline at 05/12/2015 06:20:12 AM">9 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-attachment"> <strong class="trac-field-attachment">Attachment</strong> <a href="/attachment/ticket/2322/2322.01.patch"><em>2322.01.patch</em></a><a href="/raw-attachment/ticket/2322/2322.01.patch" title="Download" class="trac-rawlink"></a> added </li> </ul> </div> <div class="change" id="trac-change-15-1431459302795916"> <h3 class="change"> <span class="threading"> <span id="comment:15" class="cnum"> <a href="#comment:15">#15</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2015-05-12T19%3A35%3A02Z&precision=second" title="See timeline at 05/12/2015 07:35:02 PM">9 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-resolution"> <strong class="trac-field-resolution">Resolution</strong> set to <em>fixed</em> </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>new</em> to <em>closed</em> </li> </ul> <div class="comment searchable"> <p>In <a class="changeset" href="/changeset/5729" title="Topics: In `bbp_move_topic_handler()`, clean both old and new forum ...">5729</a>:<br /></p><div class="message"><p>Topics: In <code>bbp_move_topic_handler()</code>, clean both old and new forum caches before updating forum hierarchies.<br /></p><p>Fixes issue where moving a topic would result in incorrect counts for both forums, due to out-of-date cache values.<br /></p><p>Props thebrandonallen. Fixes <a class="closed ticket" href="/ticket/2322" title="#2322: defect (bug): Moving Topic doesn't update _bbp_topic_count (closed: fixed)">#2322</a>.<br /></p></div> </div> </div> <div class="change" id="trac-change-16-1432283409329449"> <h3 class="change"> <span class="threading"> <span id="comment:16" class="cnum"> <a href="#comment:16">#16</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2015-05-22T08%3A30%3A09Z&precision=second" title="See timeline at 05/22/2015 08:30:09 AM">9 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>In <a class="changeset" href="/changeset/5778" title="Topics: When moving a topic update the topics post parent in ...">5778</a>:<br /></p><div class="message"><p>Topics: When moving a topic update the topics post parent in <code>bbp_move_topic_handler()</code>, includes unit test <code>test_bbp_move_topic_handler()</code><br /></p><p>Props netweb. See <a class="closed ticket" href="/ticket/2322" title="#2322: defect (bug): Moving Topic doesn't update _bbp_topic_count (closed: fixed)">#2322</a><br /></p></div> </div> </div> </div> </div> <div id="help"><strong>Note:</strong> See <a href="/wiki/TracTickets">TracTickets</a> for help on using tickets.</div> </div> <div id="altlinks"> <a class="preferences-link" href="/prefs">Trac UI Preferences</a> <h3>Download in other formats:</h3> <ul> <li class="first"> <a rel="nofollow" href="/ticket/2322?format=csv" class="csv">Comma-delimited Text</a> </li><li> <a rel="nofollow" href="/ticket/2322?format=tab" class="tab">Tab-delimited Text</a> </li><li class="last"> <a rel="nofollow" href="/ticket/2322?format=rss" class="rss">RSS Feed</a> </li> </ul></div> </div> <div id="footer"> <div class="links"> <p> See also: <a href="http://wordpress.org">WordPress.org</a> • <a href="http://bbpress.org">bbPress.org</a> • <a href="http://buddypress.org">BuddyPress.org</a> • <a href="http://ma.tt">Matt</a> • <a href="http://bbpress.org/feed/" title="RSS Feed for Articles">Blog RSS</a> </p> </div> <div class="details"> <p> <a href="http://twitter.com/bbpress" class="twitter">Follow bbPress on Twitter</a> • <a href="http://bbpress.org/about/gpl/">GPL</a> • <a href="http://bbpress.org/contact/">Contact Us</a> • <a href="http://bbpress.org/terms/">Terms of Service</a> </p> </div> </div> <script> var wpTracCurrentUser = "anonymous"; </script> <script src="https://s.w.org/style/js/navigation.min.js?20190128"></script> <script src="https://s.w.org/style/trac/jquery.caret.min.js?ver=2015-02-01"></script> <script src="https://s.w.org/style/trac/jquery.atwho.min.js?ver=1.0.1"></script> <script src="https://s.w.org/style/trac/wp-trac.js?220"></script> </body></html>
