Congratulations!

[Valid RSS] This is a valid RSS feed.

Recommendations

This feed is valid, but interoperability with the widest range of feed readers could be improved by implementing the following recommendations.

Source: https://bbpress.trac.wordpress.org/ticket/3588?format=rss

  1. <?xml version="1.0"?>
  2. <rss xmlns:dc="http://purl.org/dc/elements/1.1/" version="2.0">
  3.  <channel>
  4.    <title>bbPress Trac: Ticket #3588: Registered meta values for bbPress forum and topic post types not properly defined, causing problems with REST updates</title>
  5.    <link>https://bbpress.trac.wordpress.org/ticket/3588</link>
  6.    <description>&lt;p&gt;
  7. I've noticed in the &lt;code&gt;register_meta()&lt;/code&gt; method in &lt;code&gt;bbpress.php&lt;/code&gt;, there is a section that registers metadata for users and the custom post types that bbPress uses:
  8. &lt;/p&gt;
  9. &lt;div class="wiki-code"&gt;&lt;div class="code"&gt;&lt;pre&gt;&lt;span class="x"&gt;// Define "count" meta-type array
  10. $count = array(
  11.        // Counts are always integers
  12.        'type'              =&amp;gt; 'integer',
  13.        // Generic count description
  14.        'description'       =&amp;gt; esc_html__( 'bbPress Item Count', 'bbpress' ),
  15.        // Counts are single values
  16.        'single'            =&amp;gt; true,
  17.        // Counts should be made available in REST
  18.        'show_in_rest'      =&amp;gt; true,
  19.        // Never allow counts to go negative
  20.        'sanitize_callback' =&amp;gt; 'bbp_number_not_negative',
  21.        // All users may update count meta data
  22.        'auth_callback'     =&amp;gt; '__return_true'
  23. );
  24. /** Post **************************************************************/
  25. // Counts
  26. register_meta( 'post', '_bbp_topic_count',           $count );
  27. register_meta( 'post', '_bbp_reply_count',           $count );
  28. register_meta( 'post', '_bbp_total_topic_count',     $count );
  29. register_meta( 'post', '_bbp_total_reply_count',     $count );
  30. register_meta( 'post', '_bbp_voice_count',           $count );
  31. register_meta( 'post', '_bbp_anonymous_reply_count', $count );
  32. register_meta( 'post', '_bbp_topic_count_hidden',    $count );
  33. register_meta( 'post', '_bbp_reply_count_hidden',    $count );
  34. register_meta( 'post', '_bbp_forum_subforum_count',  $count );
  35. &lt;/span&gt;&lt;/pre&gt;&lt;/div&gt;&lt;/div&gt;&lt;p&gt;
  36. This is all fine and dandy, but these meta registrations do not define an &lt;code&gt;object_subtype&lt;/code&gt;, i.e. they are not tied to a particular post type, and are registered for all standard and custom posts.
  37. &lt;/p&gt;
  38. &lt;p&gt;
  39. Usually, this doesn't create any issue, since you don't have to register metadata to use them. But if you were to retrieve the metadata of any post in REST, the data will always be included with the post's metadata, regardless of whether the post is actually a bbPress Forum / Topic or not.
  40. &lt;/p&gt;
  41. &lt;pre class="wiki"&gt;// When retrieving post data from WordPress's Gutenberg framework,
  42. // the bbPress meta keys will always be included, even for standard post types.
  43. const meta = wp.data.select('core/editor').getEditedPostAttribute('meta');
  44. &lt;/pre&gt;&lt;p&gt;
  45. Clearly, this is an inconvenience because you will then have to strip the meta values of these unrelated bbPress meta values before you save them.
  46. &lt;/p&gt;
  47. &lt;p&gt;
  48. The fix is simple! Just attach a post type to all registered post meta!
  49. &lt;/p&gt;
  50. &lt;div class="wiki-code"&gt;&lt;div class="code"&gt;&lt;pre&gt;&lt;span class="cp"&gt;&amp;lt;?php&lt;/span&gt;
  51. &lt;span class="sd"&gt;/** Post **************************************************************/&lt;/span&gt;
  52. &lt;span class="nv"&gt;$forum&lt;/span&gt; &lt;span class="o"&gt;=&lt;/span&gt; &lt;span class="nb"&gt;array_merge&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="nv"&gt;$count&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="k"&gt;array&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="s1"&gt;'object_subtype'&lt;/span&gt; &lt;span class="o"&gt;=&amp;gt;&lt;/span&gt; &lt;span class="s1"&gt;'forum'&lt;/span&gt;&lt;span class="p"&gt;));&lt;/span&gt;
  53. &lt;span class="nv"&gt;$topic&lt;/span&gt; &lt;span class="o"&gt;=&lt;/span&gt; &lt;span class="nb"&gt;array_merge&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="nv"&gt;$count&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="k"&gt;array&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt;&lt;span class="s1"&gt;'object_subtype'&lt;/span&gt; &lt;span class="o"&gt;=&amp;gt;&lt;/span&gt; &lt;span class="s1"&gt;'topic'&lt;/span&gt;&lt;span class="p"&gt;));&lt;/span&gt;
  54. &lt;span class="c1"&gt;// Counts
  55. &lt;/span&gt;&lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_topic_count'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;           &lt;span class="nv"&gt;$forum&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  56. &lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_reply_count'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;           &lt;span class="nv"&gt;$forum&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  57. &lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_reply_count'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;           &lt;span class="nv"&gt;$topic&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  58. &lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_total_topic_count'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;     &lt;span class="nv"&gt;$forum&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  59. &lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_total_reply_count'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;     &lt;span class="nv"&gt;$forum&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  60. &lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_voice_count'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;           &lt;span class="nv"&gt;$topic&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  61. &lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_anonymous_reply_count'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="nv"&gt;$topic&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  62. &lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_topic_count_hidden'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;    &lt;span class="nv"&gt;$forum&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  63. &lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_reply_count_hidden'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;    &lt;span class="nv"&gt;$forum&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  64. &lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_reply_count_hidden'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;    &lt;span class="nv"&gt;$topic&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  65. &lt;span class="nx"&gt;register_meta&lt;/span&gt;&lt;span class="p"&gt;(&lt;/span&gt; &lt;span class="s1"&gt;'post'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt; &lt;span class="s1"&gt;'_bbp_forum_subforum_count'&lt;/span&gt;&lt;span class="p"&gt;,&lt;/span&gt;  &lt;span class="nv"&gt;$forum&lt;/span&gt; &lt;span class="p"&gt;);&lt;/span&gt;
  66. &lt;/pre&gt;&lt;/div&gt;&lt;/div&gt;&lt;p&gt;
  67. I've deployed the fix in a pull request. I hope this gets implemented soon! It is annoying to deal with.
  68. &lt;/p&gt;
  69. </description>
  70.    <language>en-us</language>
  71.    <image>
  72.      <title>bbPress Trac</title>
  73.      <url>https://bbpress.trac.wordpress.org/chrome/site/your_project_logo.png</url>
  74.      <link>https://bbpress.trac.wordpress.org/ticket/3588</link>
  75.    </image>
  76.    <generator>Trac 1.2.2</generator>
  77.    <item>
  78.      
  79.        <dc:creator>r-a-y</dc:creator>
  80.  
  81.      <pubDate>Thu, 30 Nov 2023 22:41:54 GMT</pubDate>
  82.      <title>status changed; resolution set; milestone deleted</title>
  83.      <link>https://bbpress.trac.wordpress.org/ticket/3588#comment:1</link>
  84.      <guid isPermaLink="false">https://bbpress.trac.wordpress.org/ticket/3588#comment:1</guid>
  85.      <description>
  86.          &lt;ul&gt;
  87.            &lt;li&gt;&lt;strong&gt;status&lt;/strong&gt;
  88.                changed from &lt;em&gt;new&lt;/em&gt; to &lt;em&gt;closed&lt;/em&gt;
  89.            &lt;/li&gt;
  90.            &lt;li&gt;&lt;strong&gt;resolution&lt;/strong&gt;
  91.                set to &lt;em&gt;duplicate&lt;/em&gt;
  92.            &lt;/li&gt;
  93.            &lt;li&gt;&lt;strong&gt;milestone&lt;/strong&gt;
  94.                &lt;em&gt;Awaiting Review&lt;/em&gt; deleted
  95.            &lt;/li&gt;
  96.          &lt;/ul&gt;
  97.        &lt;p&gt;
  98. Hi terresquall, I have an open ticket about this. See &lt;a class="new ticket" href="https://bbpress.trac.wordpress.org/ticket/3436" title="#3436: defect (bug): register_meta() calls should use 'object_subtype' argument (new)"&gt;#3436&lt;/a&gt;.
  99. &lt;/p&gt;
  100. &lt;p&gt;
  101. Feel free to attach a new patch if the ones I have there do not fix your problem.
  102. &lt;/p&gt;
  103.      </description>
  104.      <category>Ticket</category>
  105.    </item>
  106. </channel>
  107. </rss>

If you would like to create a banner that links to this page (i.e. this validation result), do the following:

  1. Download the "valid RSS" banner.

  2. Upload the image to your own server. (This step is important. Please do not link directly to the image on this server.)

  3. Add this HTML to your page (change the image src attribute if necessary):

If you would like to create a text link instead, here is the URL you can use:

http://www.feedvalidator.org/check.cgi?url=https%3A//bbpress.trac.wordpress.org/ticket/3588%3Fformat%3Drss

Home · About · News · Docs · Terms

 
Copyright © 2002-9 Sam Ruby, Mark Pilgrim, Joseph Walton, and Phil Ringnalda