<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"><html xmlns="http://www.w3.org/1999/xhtml"> <head> <title> #2327 (BP activity hide_sitewide not correctly reflecting associated group privacy status) – bbPress Trac </title> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> <meta http-equiv="X-UA-Compatible" content="IE=edge" /> <!--[if IE]><script type="text/javascript"> if (/^#__msie303:/.test(window.location.hash)) window.location.replace(window.location.hash.replace(/^#__msie303:/, '#')); </script><![endif]--> <link rel="search" href="/search" /> <link rel="prev" href="/ticket/2326" title="Ticket #2326" /> <link rel="last" href="/ticket/3609" title="Ticket #3609" /> <link rel="help" href="/wiki/TracGuide" /> <link rel="alternate" href="/ticket/2327?format=csv" type="text/csv" class="csv" title="Comma-delimited Text" /> <link rel="alternate" href="/ticket/2327?format=tab" type="text/tab-separated-values" class="tab" title="Tab-delimited Text" /> <link rel="alternate" href="/ticket/2327?format=rss" type="application/rss+xml" class="rss" title="RSS Feed" /> <link rel="next" href="/ticket/2328" title="Ticket #2328" /> <link rel="start" href="/wiki" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/trac.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/ticket.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/jquery-ui/jquery-ui.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/jquery-ui-addons.css?v=220" /> <link rel="icon" href="https://bbpress.org/favicon.ico" type="image/x-icon" /> <link rel="first" href="/ticket/1" title="Ticket #1" /> <style id="trac-noscript" type="text/css">.trac-noscript { display: none !important }</style> <link type="application/opensearchdescription+xml" rel="search" href="/search/opensearch" title="Search bbPress Trac" /> <script type="text/javascript"> var auto_preview_timeout=2.0; var form_token="ed1efbb850e0470c7f2d79fd"; var jquery_ui={"ampm":true,"date_format":"mm/dd/yy","day_names":{"abbreviated":["Sun","Mon","Tue","Wed","Thu","Fri","Sat"],"narrow":["Su","Mo","Tu","We","Th","Fr","Sa"],"wide":["Sunday","Monday","Tuesday","Wednesday","Thursday","Friday","Saturday"]},"default_timezone":null,"first_week_day":0,"month_names":{"abbreviated":["Jan","Feb","Mar","Apr","May","Jun","Jul","Aug","Sep","Oct","Nov","Dec"],"wide":["January","February","March","April","May","June","July","August","September","October","November","December"]},"period_names":{"am":["AM","AM"],"pm":["PM","PM"]},"show_timezone":false,"time_format":"hh:mm:ss TT","timepicker_separator":" ","timezone_iso8601":false,"timezone_list":null}; var comments_prefs={"comments_order":"oldest","show_comments":"true","show_prop_changes":"true"}; </script> <link rel="dns-prefetch" href="//fonts.googleapis.com" /> <link rel="dns-prefetch" href="//www.googletagmanager.com" /> <script>//<![CDATA[ (function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start': new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0], j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src= 'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); })(window,document,'script','dataLayer','GTM-P24PF4B'); //]]></script> <link rel="stylesheet" href="//fonts.googleapis.com/css?family=Open+Sans%3A300italic%2C400italic%2C600italic%2C300%2C400%2C600&subset=latin%2Clatin-ext&ver=3.8.1-alpha" type="text/css" media="all" /> <link type="text/css" media="screen" rel="stylesheet" href="//bbpress.org/wp-content/themes/bb-base/style.css?v=24" /> <link type="text/css" media="screen" rel="stylesheet" href="//bbpress.org/wp-content/themes/bb-base/style-bbpress.css?v=24" /> <meta name="viewport" content="width=device-width" /> <link rel="stylesheet" href="https://s.w.org/wp-includes/css/dashicons.min.css?20150710" type="text/css" /> <link rel="stylesheet" type="text/css" href="https://s.w.org/style/trac/wp-trac.css?220" /> <script src="https://s.w.org/style/trac/common/js/jquery.js?v=220"></script> <link rel="canonical" href="https://bbpress.trac.wordpress.org/ticket/2327" /> <script src="https://s.w.org/style/trac/common/js/babel.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/trac.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/search.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/folding.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/wikitoolbar.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/resizer.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/auto_preview.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui-addons.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui-i18n.js?v=220"></script> <script type="text/javascript"> jQuery("#trac-noscript").remove(); jQuery(document).ready(function($) { $(".trac-autofocus").focus(); $(".trac-target-new").attr("target", "_blank"); if ($.ui) { /* is jquery-ui added? */ $(".trac-datepicker:not([readonly])").prop("autocomplete", "off").datepicker(); $(".trac-datetimepicker:not([readonly])").prop("autocomplete", "off").datetimepicker(); $("#main").addClass("trac-nodatetimehint"); } $(".trac-disable").disableSubmit(".trac-disable-determinant"); setTimeout(function() { $(".trac-scroll").scrollToTop() }, 1); $(".trac-disable-on-submit").disableOnSubmit(); }); </script> <script src="https://s.w.org/style/trac/common/js/threaded_comments.js?v=220"></script> <script type="text/javascript"> jQuery(document).ready(function($) { $("div.description").find("h1,h2,h3,h4,h5,h6").addAnchor(_("Link to this section")); $(".foldable").enableFolding(false, true); /*<![CDATA[*/ $("#attachments").toggleClass("collapsed"); $("#trac-up-attachments").click(function () { $("#attachments").removeClass("collapsed"); return true; }); $("#modify").parent().toggleClass("collapsed"); $(".trac-topnav a").click(function() { $("#modify").parent().removeClass("collapsed"); }); function setRevertHandler() { $("button.trac-revert").click(function() { var div = $("div", this); var field_name = div[0].id.substr(7); var field_value = div.text(); var input = $("#propertyform *[name=field_" + field_name + "]"); if (input.length > 0) { if (input.filter("input[type=radio]").length > 0) { input.val([field_value]); } else if (input.filter("input[type=checkbox]").length > 0) { input.val(field_value == "1" ? [field_value] : []); } else { input.val(field_value); } } else { // Special case for CC checkbox input = $("#propertyform input[name=cc_update]").val([]); } input.change(); // Remove the revert button if ($(this).closest("tbody").children("tr").length === 1) $(this).closest(".trac-change-panel").remove(); else $(this).closest("tr").remove(); return false; }); } setRevertHandler(); var comment_focused = false; $("#comment").focus(function() { comment_focused = true; }) .blur(function() { comment_focused = false; }); $("#propertyform").autoSubmit({preview: '1'}, function(data, reply) { var items = $(reply); // Update ticket box $("#ticket").replaceWith(items.filter('#ticket')); // Replaces content of #changelog, without recreating it $("#changelog").empty().append(items.filter("#changelog").contents()); // Apply comments order and "Show" preferences applyCommentsOrder( $('#prefs input[name="trac-comments-order"]:checked').val()); // Show warning var new_changes = $("#changelog .trac-new"); $("#trac-edit-warning").toggle(new_changes.length != 0); if (new_changes.length != 0) $("#changelog").parent().show().removeClass("collapsed"); // Update view time $("#propertyform input[name='view_time']").replaceWith(items.filter("input[name='view_time']")); // Update preview var preview = $("#ticketchange").html(items.filter('#preview').children()); var show_preview = preview.children().length != 0; $("#ticketchange").toggle(show_preview); setRevertHandler(); // Execute scripts to load stylesheets items.filter("script").appendTo("head"); }, "#ticketchange .trac-loading"); $("#trac-comment-editor").autoSubmit({preview_comment: '1'}, function(data, reply) { var comment = $("#trac-comment-editor").next("div.comment").html(reply); comment.toggle(comment.children().length != 0); }, "#changelog .trac-loading"); /*]]>*/ }); </script> </head> <body id="wordpress-org" class="bbpress trac wporg-make make-bbpress"> <noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-P24PF4B" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript> <dl id="accessibility"> <dt>Skip to:</dt> <dd><a href="#content" title="Skip to content">Content</a></dd> </dl> <div id="wporg-header"> <div id="header-inner"> <button id="mobile-menu-button" aria-expanded="false"><span class="screen-reader-text">Toggle Menu</span></button> <ul id="wporg-header-menu"> <li><a href="https://bbpress.org/about/">About</a></li> <li><a href="https://bbpress.org/plugins/">Plugins</a></li> <li><a href="https://bbpress.org/themes/">Themes</a></li> <li><a href="https://codex.bbpress.org/">Documentation</a></li> <li><a href="https://bbpress.org/blog/">Blog</a></li> <li><a href="https://bbpress.org/forums/">Support</a></li> <li class="download"><a href="https://bbpress.org/download/">Download</a></li> </ul> <h1><a href="https://bbpress.org">bbPress.org</a></h1> </div> </div> <div id="subnav"> <div id="subnav-inner"> <ul id="nav-user" class="menu"> <li class="last first"> <a href="https://login.wordpress.org/?redirect_to=https%3A%2F%2Fbbpress.trac.wordpress.org%2Fticket%2F2327" class="login">Login</a></li> </ul> </div> </div> <div id="banner"> <form id="search" action="/search" method="get"> <div> <label for="proj-search">Search:</label> <input type="text" id="proj-search" name="q" size="18" value="" /> <input type="submit" value="Search" /> </div> </form> </div> <div id="mainnav" class="nav"> <ul> <li class="first"><a href="/timeline">Timeline</a></li><li class="active"><a href="/report">View Tickets</a></li><li><a href="/roadmap">Roadmap</a></li><li><a href="/browser">Browse Source</a></li><li class="last"><a href="/ticketgraph">Ticket Graph</a></li> </ul> </div> <div id="main"> <div id="ctxtnav" class="nav"> <h2>Context Navigation</h2> <ul> <li class="first"><span>← <a class="prev" href="/ticket/2326" title="Ticket #2326">Previous Ticket</a></span></li><li class="last"><span><a class="next" href="/ticket/2328" title="Ticket #2328">Next Ticket</a> →</span></li> </ul> <hr /> </div> <div id="content" class="ticket"> <div id="ticket" class="trac-content "> <div class="date"> <p>Opened <a class="timeline" href="/timeline?from=2013-05-05T01%3A51%3A10Z&precision=second" title="See timeline at 05/05/2013 01:51:10 AM">12 years ago</a></p> <p>Closed <a class="timeline" href="/timeline?from=2013-05-06T02%3A38%3A53Z&precision=second" title="See timeline at 05/06/2013 02:38:53 AM">11 years ago</a></p> <p>Last modified <a class="timeline" href="/timeline?from=2013-11-04T06%3A05%3A17Z&precision=second" title="See timeline at 11/04/2013 06:05:17 AM">11 years ago</a></p> </div> <h2> <a href="/ticket/2327" class="trac-id">#2327</a> <span class="trac-status"> <a href="/query?status=closed">closed</a> </span> <span class="trac-type"> <a href="/query?status=!closed&type=defect+(bug)">defect (bug)</a> </span> <span class="trac-resolution"> (<a href="/query?status=closed&resolution=fixed">fixed</a>) </span> </h2> <h1 id="trac-ticket-title" class="searchable"> <span class="summary">BP activity hide_sitewide not correctly reflecting associated group privacy status</span> </h1> <table class="properties"> <tr> <th id="h_reporter">Reported by:</th> <td headers="h_reporter" class="searchable"> <a href="https://profiles.wordpress.org/boonebgorges" data-nicename="boonebgorges"> <img class="avatar" src="https://wordpress.org/grav-redirect.php?user=boonebgorges&s=48" srcset="https://wordpress.org/grav-redirect.php?user=boonebgorges&s=96 2x" height="48" width="48" alt="boonebgorges's profile" /> </a> <a class="trac-author" href="/query?status=!closed&reporter=boonebgorges">boonebgorges</a></td> <th id="h_owner">Owned by:</th> <td headers="h_owner"> <a href="https://profiles.wordpress.org/johnjamesjacoby"> <img class="avatar" src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="johnjamesjacoby's profile" /> </a> <a class="trac-author" href="/query?status=!closed&owner=johnjamesjacoby">johnjamesjacoby</a></td> </tr> <tr> <th id="h_milestone"> Milestone: </th> <td headers="h_milestone"> <a class="closed milestone" href="/milestone/2.3.2" title="Completed 11 years ago (05/06/2013 09:55:16 PM)">2.3.2</a> </td> <th id="h_priority"> Priority: </th> <td headers="h_priority"> <a href="/query?status=!closed&priority=high">high</a> </td> </tr><tr> <th id="h_severity"> Severity: </th> <td headers="h_severity"> <a href="/query?status=!closed&severity=major">major</a> </td> <th id="h_version"> Version: </th> <td headers="h_version"> <a href="/query?status=!closed&version=trunk">trunk</a> </td> </tr><tr> <th id="h_component"> Component: </th> <td headers="h_component"> <a href="/query?status=!closed&component=Extend+-+BuddyPress">Extend - BuddyPress</a> </td> <th id="h_keywords"> Keywords: </th> <td headers="h_keywords" class="searchable"> <a href="/query?status=!closed&keywords=~commit">commit</a> </td> </tr><tr> <th id="h_cc"> Cc: </th> <td headers="h_cc" class="searchable"> stephen@… </td> <th class="missing"> </th> <td> </td> </tr> </table> <div class="description"> <h3 id="comment:description"> Description <a href="/ticket/2327?action=diff&version=1" class="lastmod trac-diff" title="2013-05-05 18:35:10.848729+00:00"> (last modified by <span class="trac-author">johnjamesjacoby</span>) </a> </h3> <div class="searchable"> <p>The <code>bbp_is_forum_public()</code> check in <a class="ext-link" href="https://bbpress.trac.wordpress.org/browser/trunk/includes/extend/buddypress/activity.php#L427"><span class="icon"></span>https://bbpress.trac.wordpress.org/browser/trunk/includes/extend/buddypress/activity.php#L427</a> is not working properly. This method appears to run twice on topic creation - once when the topic is created, and then again on the <code>bbp_new_topic</code> hook. The first time around, the <code>$forum_id</code> variable is set to 0, so <code>! bbp_is_forum_public()</code> check is returning <code>true</code>, presumably because forum 0 does not exist and therefore is not public. The second time, the correct <code>$forum_id</code> is getting passed through, but its return value is not respecting the group's status (public vs private/hidden).<br /></p><p>I haven't dug any deeper, as I'm not sure how bbPress's forum privacy is set against BP group privacy, and I figured you might know just where to look :)<br /></p><p>See <a class="ext-link" href="https://buddypress.trac.wordpress.org/ticket/4976"><span class="icon"></span>https://buddypress.trac.wordpress.org/ticket/4976</a><br /></p> </div> </div></div> <div> <div class="trac-noscript" style="position: relative"> <form id="prefs" method="get" action="/prefs" style="position: absolute; right: 0"> <div id="trac-comments-order"> <input type="radio" id="trac-comments-oldest" name="trac-comments-order" value="oldest" checked="checked" /> <label for="trac-comments-oldest">Oldest first</label> <input type="radio" id="trac-comments-newest" name="trac-comments-order" value="newest" /> <label for="trac-comments-newest">Newest first</label> <span id="trac-threaded-toggle" style="display: none"> <input type="radio" id="trac-comments-threaded" name="trac-comments-order" value="threaded" /> <label for="trac-comments-threaded">Threaded</label> </span> </div> <div> <input id="trac-show-comments-toggle" type="checkbox" checked="checked" /> <label for="trac-show-comments-toggle">Show comments</label> <input id="trac-show-property-changes-toggle" type="checkbox" /> <label for="trac-show-property-changes-toggle">Show property changes</label> </div> </form> </div> <h3 class="foldable">Change History <span class="trac-count">(14)</span></h3> <div id="changelog"> <div class="change" id="trac-change-1-1367778910848729"> <h3 class="change"> <span class="threading"> <span id="comment:1" class="cnum"> <a href="#comment:1">#1</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-05-05T18%3A35%3A10Z&precision=second" title="See timeline at 05/05/2013 06:35:10 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-description"> <strong class="trac-field-description">Description</strong> modified (<a href="/ticket/2327?action=diff&version=1">diff</a>) </li> </ul> </div> <div class="change" id="trac-change-2-1367785550754672"> <h3 class="change"> <span class="threading"> <span id="comment:2" class="cnum"> <a href="#comment:2">#2</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/kraigg" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=kraigg&s=48" srcset="https://wordpress.org/grav-redirect.php?user=kraigg&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="kraigg" data-nicename="kraigg"><span class="trac-author">kraigg</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-05-05T20%3A25%3A50Z&precision=second" title="See timeline at 05/05/2013 08:25:50 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-cc"> <strong class="trac-field-cc">Cc</strong> <em>kraigg@…</em> added </li> </ul> </div> <div class="change" id="trac-change-3-1367807749547122"> <h3 class="change"> <span class="threading"> <span id="comment:3" class="cnum"> <a href="#comment:3">#3</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-05-06T02%3A35%3A49Z&precision=second" title="See timeline at 05/06/2013 02:35:49 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-cc"> <strong class="trac-field-cc">Cc</strong> <em>kraigg@…</em> removed </li><li class="trac-field-keywords"> <strong class="trac-field-keywords">Keywords</strong> <em>commit</em> added </li><li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> changed from <em>Awaiting Review</em> to <em>2.3.2</em> </li><li class="trac-field-owner"> <strong class="trac-field-owner">Owner</strong> set to <em>johnjamesjacoby</em> </li> </ul> <div class="comment searchable"> <p>Able to duplicate. Fix imminent. For 2.3.2.<br /></p> </div> </div> <div class="change" id="trac-change-4-1367807933514300"> <h3 class="change"> <span class="threading"> <span id="comment:4" class="cnum"> <a href="#comment:4">#4</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-05-06T02%3A38%3A53Z&precision=second" title="See timeline at 05/06/2013 02:38:53 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-resolution"> <strong class="trac-field-resolution">Resolution</strong> set to <em>fixed</em> </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>new</em> to <em>closed</em> </li> </ul> <div class="comment searchable"> <p>In <a class="changeset" href="/changeset/4881" title="In the BuddyPress Activity extension, move _update() methods from ...">4881</a>:<br /></p><div class="message"><p>In the <a class="wiki" href="/wiki/BuddyPress">BuddyPress</a> Activity extension, move _update() methods from 'wp_insert_post' onto 'edit_post' action to prevent running them on topic/reply creation accidentally. Fixes bug causing hide_sitewide to incorrectly be set to true on some installations. Also some code clean-up and additional type-casting where appropriate. Fixes <a class="closed ticket" href="/ticket/2327" title="#2327: defect (bug): BP activity hide_sitewide not correctly reflecting associated group ... (closed: fixed)">#2327</a> (trunk)<br /></p></div> </div> </div> <div class="change" id="trac-change-5-1367808779898706"> <h3 class="change"> <span class="threading"> <span id="comment:5" class="cnum"> <a href="#comment:5">#5</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-05-06T02%3A52%3A59Z&precision=second" title="See timeline at 05/06/2013 02:52:59 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>In <a class="changeset" href="/changeset/4882" title="In the BuddyPress Activity extension, move _update() methods from ...">4882</a>:<br /></p><div class="message"><p>In the <a class="wiki" href="/wiki/BuddyPress">BuddyPress</a> Activity extension, move _update() methods from 'wp_insert_post' onto 'edit_post' action to prevent running them on topic/reply creation accidentally. Fixes bug causing hide_sitewide to incorrectly be set to true on some installations. Also some code clean-up and additional type-casting where appropriate. Fixes <a class="closed ticket" href="/ticket/2327" title="#2327: defect (bug): BP activity hide_sitewide not correctly reflecting associated group ... (closed: fixed)">#2327</a> (2.3 branch)<br /></p></div> </div> </div> <div class="change" id="trac-change-6-1367887078432791"> <h3 class="change"> <span class="threading"> <span id="comment:6" class="cnum"> <a href="#comment:6">#6</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/kraigg" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=kraigg&s=48" srcset="https://wordpress.org/grav-redirect.php?user=kraigg&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="kraigg" data-nicename="kraigg"><span class="trac-author">kraigg</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-05-07T00%3A37%3A58Z&precision=second" title="See timeline at 05/07/2013 12:37:58 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Thanks for the fix with bbPress 2.3.2, but I found a really strange related issue.<br /></p><p>Posting new topics and replies to existing private group forums still show up in the activity stream.<br /></p><p>But if I create new private group forums using the latest bbPress 2.3.2, the topics and replies in these newly created private groups are correctly hidden in the activity stream.<br /></p><p>I double-checked the existing private groups and the new private groups, and the settings are identical. I also tried to use the Tools > Forums to recaculate and resync the forums, but the problem remains.<br /></p> </div> </div> <div class="change" id="trac-change-7-1377272106603945"> <h3 class="change"> <span class="threading"> <span id="comment:7" class="cnum"> <a href="#comment:7">#7</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/petervandoorn" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=petervandoorn&s=48" srcset="https://wordpress.org/grav-redirect.php?user=petervandoorn&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="petervandoorn" data-nicename="petervandoorn"><span class="trac-author">petervandoorn</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-08-23T15%3A35%3A06Z&precision=second" title="See timeline at 08/23/2013 03:35:06 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>This is still an issue for me. BP 1.8 with bbPress 2.3.2 on WP 3.6 still sees forum posts in Private groups appearing in non-group members’ activity streams! In my case, these groups & forums were set up in BP 1.6 and then migrated over to bbPress 2.3.2 when BP hit 1.7.<br /></p> </div> </div> <div class="change" id="trac-change-8-1377320004999649"> <h3 class="change"> <span class="threading"> <span id="comment:8" class="cnum"> <a href="#comment:8">#8</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/vogelsang" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=vogelsang&s=48" srcset="https://wordpress.org/grav-redirect.php?user=vogelsang&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="vogelsang" data-nicename="vogelsang"><span class="trac-author">vogelsang</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-08-24T04%3A53%3A24Z&precision=second" title="See timeline at 08/24/2013 04:53:24 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>I got this problem as well. I have migrated from Drupal and afterwards the posts from the old private forums shows up on the user profiles after I made them private. New private forums (made after the migration) works fine. <br /></p><p>I have done full repairs of the forum before and after I made my old drupal forums private. I haven't looked into the db for explanations yet.<br /></p><p>I am using bbpress 2.3.2, WP 3.6, and buddypress 1.8.1.<br /></p> </div> </div> <div class="change" id="trac-change-9-1377514736067549"> <h3 class="change"> <span class="threading"> <span id="comment:9" class="cnum"> <a href="#comment:9">#9</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-08-26T10%3A58%3A56Z&precision=second" title="See timeline at 08/26/2013 10:58:56 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-cc"> <strong class="trac-field-cc">Cc</strong> <em>stephen@…</em> added </li> </ul> <div class="comment searchable"> <p>I am wondering if there is something not quite right with tools recount with an imported <code>_bbp_</code> value conflicting somewhere, need to dig around in the database and take a look some SQL examples or new private forums/topics vs imported private forums/topics.<br /></p> </div> </div> <div class="change" id="trac-change-10-1378207916244013"> <h3 class="change"> <span class="threading"> <span id="comment:10" class="cnum"> <a href="#comment:10">#10</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/petervandoorn" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=petervandoorn&s=48" srcset="https://wordpress.org/grav-redirect.php?user=petervandoorn&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="petervandoorn" data-nicename="petervandoorn"><span class="trac-author">petervandoorn</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-09-03T11%3A31%3A56Z&precision=second" title="See timeline at 09/03/2013 11:31:56 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Update: bbPress 2.4 does not fix the bug!<br /></p> </div> </div> <div class="change" id="trac-change-11-1383429048129267"> <h3 class="change"> <span class="threading"> <span id="comment:11" class="cnum"> <a href="#comment:11">#11</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/vegaskev" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=vegaskev&s=48" srcset="https://wordpress.org/grav-redirect.php?user=vegaskev&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="vegaskev" data-nicename="vegaskev"><span class="trac-author">vegaskev</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-02T21%3A50%3A48Z&precision=second" title="See timeline at 11/02/2013 09:50:48 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Just wanted to note that I have an installation exhibiting the exact same issues. My private bbpress forums inside of private buddypress groups are visible to all members, even though they are not members of any groups or forums within the installation.<br /></p><p>I have double-checked and all groups and forums are set to private.<br /></p><p>I also, migrated from BP to bp & bbpress when bp 1.7 was released.<br /></p><p><strong>Seriously think this ticket should be reopened</strong>. I am running <a class="wiki" href="/wiki/BuddyPress">BuddyPress</a> 1.8.1 and bbPress 2.4.1 <br /></p> </div> <div class="trac-lastedit "> Last edited <a class="timeline" href="/timeline?from=2013-11-02T21%3A53%3A27Z&precision=second" title="See timeline at 11/02/2013 09:53:27 PM">11 years ago</a> by <span class="trac-author">vegaskev</span> (<a href="/ticket/2327?cversion=0&cnum_hist=11#comment:11">previous</a>) (<a href="/ticket/2327?action=comment-diff&cnum=11&version=1">diff</a>) </div> </div> <div class="change" id="trac-change-12-1383429241643755"> <h3 class="change"> <span class="threading"> <span id="comment:12" class="cnum"> <a href="#comment:12">#12</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/vegaskev" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=vegaskev&s=48" srcset="https://wordpress.org/grav-redirect.php?user=vegaskev&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="vegaskev" data-nicename="vegaskev"><span class="trac-author">vegaskev</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-02T21%3A54%3A01Z&precision=second" title="See timeline at 11/02/2013 09:54:01 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-priority"> <strong class="trac-field-priority">Priority</strong> changed from <em>normal</em> to <em>high</em> </li> </ul> </div> <div class="change" id="trac-change-13-1383470787193737"> <h3 class="change"> <span class="threading"> <span id="comment:13" class="cnum"> <a href="#comment:13">#13</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-03T09%3A26%3A27Z&precision=second" title="See timeline at 11/03/2013 09:26:27 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>@vegaskev<br /></p><p>What happens if you run the following repair tools from /wp-admin/tools.php?page=bbp-repair<br /></p><blockquote><p>Recalculate private and hidden forums<br />Repair <a class="wiki" href="/wiki/BuddyPress">BuddyPress</a> Group Forum relationships<br /></p></blockquote> </div> </div> <div class="change" id="trac-change-14-1383545117072321"> <h3 class="change"> <span class="threading"> <span id="comment:14" class="cnum"> <a href="#comment:14">#14</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-04T06%3A05%3A17Z&precision=second" title="See timeline at 11/04/2013 06:05:17 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <ul><li>Just installed <a class="wiki" href="/wiki/BuddyPress">BuddyPress</a> v1.6.5 with bbPress Group Forums</li><li>Migrated from bbPress Group Forums to bbPress v2.4.1 per <a class="ext-link" href="http://codex.buddypress.org/getting-started/guides/migrating-from-old-forums-to-bbpress-2/"><span class="icon"></span>this doc</a></li><li>Cannot see any private/hidden posts to groups or forums, seeing only what I expect I should see.</li><li>Upgraded <a class="wiki" href="/wiki/BuddyPress">BuddyPress</a> from v1.6.5 to v1.7.3, same, everything still as expected</li><li>Upgraded <a class="wiki" href="/wiki/BuddyPress">BuddyPress</a> from v1.7.3 to v1.8.1, same, everything still as expected</li><li>All of the above was done browsing the site not logged in, i.e. generic website visitor</li><li>Created a new user, standard with no changes to out of the box permissions/roles etc.</li><li>User joined the open 'Public Group' and I still only see what expect to see. Cannot see any new updates, topics, replies etc made to the 'hidden' or 'private' groups or forums of the site.</li></ul><p>Hardest thing here is we are not able to reproduce this issue, not saying it isn't happening.<br /></p><p>Try the recalc tools I listed above, disable all other plugins except bbPress & <a class="wiki" href="/wiki/BuddyPress">BuddyPress</a>, use <a class="wiki" href="/wiki/WordPress">WordPress</a>' Twenty Thirteen theme, share some links to your site showing examples of where things are showing as not working as expected.<br /></p> </div> </div> </div> </div> <div id="help"><strong>Note:</strong> See <a href="/wiki/TracTickets">TracTickets</a> for help on using tickets.</div> </div> <div id="altlinks"> <a class="preferences-link" href="/prefs">Trac UI Preferences</a> <h3>Download in other formats:</h3> <ul> <li class="first"> <a rel="nofollow" href="/ticket/2327?format=csv" class="csv">Comma-delimited Text</a> </li><li> <a rel="nofollow" href="/ticket/2327?format=tab" class="tab">Tab-delimited Text</a> </li><li class="last"> <a rel="nofollow" href="/ticket/2327?format=rss" class="rss">RSS Feed</a> </li> </ul></div> </div> <div id="footer"> <div class="links"> <p> See also: <a href="http://wordpress.org">WordPress.org</a> • <a href="http://bbpress.org">bbPress.org</a> • <a href="http://buddypress.org">BuddyPress.org</a> • <a href="http://ma.tt">Matt</a> • <a href="http://bbpress.org/feed/" title="RSS Feed for Articles">Blog RSS</a> </p> </div> <div class="details"> <p> <a href="http://twitter.com/bbpress" class="twitter">Follow bbPress on Twitter</a> • <a href="http://bbpress.org/about/gpl/">GPL</a> • <a href="http://bbpress.org/contact/">Contact Us</a> • <a href="http://bbpress.org/terms/">Terms of Service</a> </p> </div> </div> <script> var wpTracCurrentUser = "anonymous"; </script> <script src="https://s.w.org/style/js/navigation.min.js?20190128"></script> <script src="https://s.w.org/style/trac/jquery.caret.min.js?ver=2015-02-01"></script> <script src="https://s.w.org/style/trac/jquery.atwho.min.js?ver=1.0.1"></script> <script src="https://s.w.org/style/trac/wp-trac.js?220"></script> </body></html>
