<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"><html xmlns="http://www.w3.org/1999/xhtml"> <head> <title> #2393 (bbp_user_can_view_forum() and custom user ID) – bbPress Trac </title> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> <meta http-equiv="X-UA-Compatible" content="IE=edge" /> <!--[if IE]><script type="text/javascript"> if (/^#__msie303:/.test(window.location.hash)) window.location.replace(window.location.hash.replace(/^#__msie303:/, '#')); </script><![endif]--> <link rel="search" href="/search" /> <link rel="prev" href="/ticket/2392" title="Ticket #2392" /> <link rel="last" href="/ticket/3609" title="Ticket #3609" /> <link rel="help" href="/wiki/TracGuide" /> <link rel="alternate" href="/ticket/2393?format=csv" type="text/csv" class="csv" title="Comma-delimited Text" /> <link rel="alternate" href="/ticket/2393?format=tab" type="text/tab-separated-values" class="tab" title="Tab-delimited Text" /> <link rel="alternate" href="/ticket/2393?format=rss" type="application/rss+xml" class="rss" title="RSS Feed" /> <link rel="next" href="/ticket/2395" title="Ticket #2395" /> <link rel="start" href="/wiki" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/trac.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/ticket.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/jquery-ui/jquery-ui.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/jquery-ui-addons.css?v=220" /> <link rel="icon" href="https://bbpress.org/favicon.ico" type="image/x-icon" /> <link rel="first" href="/ticket/1" title="Ticket #1" /> <style id="trac-noscript" type="text/css">.trac-noscript { display: none !important }</style> <link type="application/opensearchdescription+xml" rel="search" href="/search/opensearch" title="Search bbPress Trac" /> <script type="text/javascript"> var auto_preview_timeout=2.0; var form_token="7c124ad8d416c31d8f607b30"; var jquery_ui={"ampm":true,"date_format":"mm/dd/yy","day_names":{"abbreviated":["Sun","Mon","Tue","Wed","Thu","Fri","Sat"],"narrow":["Su","Mo","Tu","We","Th","Fr","Sa"],"wide":["Sunday","Monday","Tuesday","Wednesday","Thursday","Friday","Saturday"]},"default_timezone":null,"first_week_day":0,"month_names":{"abbreviated":["Jan","Feb","Mar","Apr","May","Jun","Jul","Aug","Sep","Oct","Nov","Dec"],"wide":["January","February","March","April","May","June","July","August","September","October","November","December"]},"period_names":{"am":["AM","AM"],"pm":["PM","PM"]},"show_timezone":false,"time_format":"hh:mm:ss TT","timepicker_separator":" ","timezone_iso8601":false,"timezone_list":null}; var comments_prefs={"comments_order":"oldest","show_comments":"true","show_prop_changes":"true"}; </script> <link rel="dns-prefetch" href="//fonts.googleapis.com" /> <link rel="dns-prefetch" href="//www.googletagmanager.com" /> <script>//<![CDATA[ (function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start': new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0], j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src= 'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); })(window,document,'script','dataLayer','GTM-P24PF4B'); //]]></script> <link rel="stylesheet" href="//fonts.googleapis.com/css?family=Open+Sans%3A300italic%2C400italic%2C600italic%2C300%2C400%2C600&subset=latin%2Clatin-ext&ver=3.8.1-alpha" type="text/css" media="all" /> <link type="text/css" media="screen" rel="stylesheet" href="//bbpress.org/wp-content/themes/bb-base/style.css?v=24" /> <link type="text/css" media="screen" rel="stylesheet" href="//bbpress.org/wp-content/themes/bb-base/style-bbpress.css?v=24" /> <meta name="viewport" content="width=device-width" /> <link rel="stylesheet" href="https://s.w.org/wp-includes/css/dashicons.min.css?20150710" type="text/css" /> <link rel="stylesheet" type="text/css" href="https://s.w.org/style/trac/wp-trac.css?220" /> <script src="https://s.w.org/style/trac/common/js/jquery.js?v=220"></script> <link rel="canonical" href="https://bbpress.trac.wordpress.org/ticket/2393" /> <script src="https://s.w.org/style/trac/common/js/babel.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/trac.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/search.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/folding.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/wikitoolbar.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/resizer.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/auto_preview.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui-addons.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui-i18n.js?v=220"></script> <script type="text/javascript"> jQuery("#trac-noscript").remove(); jQuery(document).ready(function($) { $(".trac-autofocus").focus(); $(".trac-target-new").attr("target", "_blank"); if ($.ui) { /* is jquery-ui added? */ $(".trac-datepicker:not([readonly])").prop("autocomplete", "off").datepicker(); $(".trac-datetimepicker:not([readonly])").prop("autocomplete", "off").datetimepicker(); $("#main").addClass("trac-nodatetimehint"); } $(".trac-disable").disableSubmit(".trac-disable-determinant"); setTimeout(function() { $(".trac-scroll").scrollToTop() }, 1); $(".trac-disable-on-submit").disableOnSubmit(); }); </script> <script src="https://s.w.org/style/trac/common/js/threaded_comments.js?v=220"></script> <script type="text/javascript"> jQuery(document).ready(function($) { $("div.description").find("h1,h2,h3,h4,h5,h6").addAnchor(_("Link to this section")); $(".foldable").enableFolding(false, true); /*<![CDATA[*/ $("#attachments").toggleClass("collapsed"); $("#trac-up-attachments").click(function () { $("#attachments").removeClass("collapsed"); return true; }); $("#modify").parent().toggleClass("collapsed"); $(".trac-topnav a").click(function() { $("#modify").parent().removeClass("collapsed"); }); function setRevertHandler() { $("button.trac-revert").click(function() { var div = $("div", this); var field_name = div[0].id.substr(7); var field_value = div.text(); var input = $("#propertyform *[name=field_" + field_name + "]"); if (input.length > 0) { if (input.filter("input[type=radio]").length > 0) { input.val([field_value]); } else if (input.filter("input[type=checkbox]").length > 0) { input.val(field_value == "1" ? [field_value] : []); } else { input.val(field_value); } } else { // Special case for CC checkbox input = $("#propertyform input[name=cc_update]").val([]); } input.change(); // Remove the revert button if ($(this).closest("tbody").children("tr").length === 1) $(this).closest(".trac-change-panel").remove(); else $(this).closest("tr").remove(); return false; }); } setRevertHandler(); var comment_focused = false; $("#comment").focus(function() { comment_focused = true; }) .blur(function() { comment_focused = false; }); $("#propertyform").autoSubmit({preview: '1'}, function(data, reply) { var items = $(reply); // Update ticket box $("#ticket").replaceWith(items.filter('#ticket')); // Replaces content of #changelog, without recreating it $("#changelog").empty().append(items.filter("#changelog").contents()); // Apply comments order and "Show" preferences applyCommentsOrder( $('#prefs input[name="trac-comments-order"]:checked').val()); // Show warning var new_changes = $("#changelog .trac-new"); $("#trac-edit-warning").toggle(new_changes.length != 0); if (new_changes.length != 0) $("#changelog").parent().show().removeClass("collapsed"); // Update view time $("#propertyform input[name='view_time']").replaceWith(items.filter("input[name='view_time']")); // Update preview var preview = $("#ticketchange").html(items.filter('#preview').children()); var show_preview = preview.children().length != 0; $("#ticketchange").toggle(show_preview); setRevertHandler(); // Execute scripts to load stylesheets items.filter("script").appendTo("head"); }, "#ticketchange .trac-loading"); $("#trac-comment-editor").autoSubmit({preview_comment: '1'}, function(data, reply) { var comment = $("#trac-comment-editor").next("div.comment").html(reply); comment.toggle(comment.children().length != 0); }, "#changelog .trac-loading"); /*]]>*/ }); </script> </head> <body id="wordpress-org" class="bbpress trac wporg-make make-bbpress"> <noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-P24PF4B" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript> <dl id="accessibility"> <dt>Skip to:</dt> <dd><a href="#content" title="Skip to content">Content</a></dd> </dl> <div id="wporg-header"> <div id="header-inner"> <button id="mobile-menu-button" aria-expanded="false"><span class="screen-reader-text">Toggle Menu</span></button> <ul id="wporg-header-menu"> <li><a href="https://bbpress.org/about/">About</a></li> <li><a href="https://bbpress.org/plugins/">Plugins</a></li> <li><a href="https://bbpress.org/themes/">Themes</a></li> <li><a href="https://codex.bbpress.org/">Documentation</a></li> <li><a href="https://bbpress.org/blog/">Blog</a></li> <li><a href="https://bbpress.org/forums/">Support</a></li> <li class="download"><a href="https://bbpress.org/download/">Download</a></li> </ul> <h1><a href="https://bbpress.org">bbPress.org</a></h1> </div> </div> <div id="subnav"> <div id="subnav-inner"> <ul id="nav-user" class="menu"> <li class="last first"> <a href="https://login.wordpress.org/?redirect_to=https%3A%2F%2Fbbpress.trac.wordpress.org%2Fticket%2F2393" class="login">Login</a></li> </ul> </div> </div> <div id="banner"> <form id="search" action="/search" method="get"> <div> <label for="proj-search">Search:</label> <input type="text" id="proj-search" name="q" size="18" value="" /> <input type="submit" value="Search" /> </div> </form> </div> <div id="mainnav" class="nav"> <ul> <li class="first"><a href="/timeline">Timeline</a></li><li class="active"><a href="/report">View Tickets</a></li><li><a href="/roadmap">Roadmap</a></li><li><a href="/browser">Browse Source</a></li><li class="last"><a href="/ticketgraph">Ticket Graph</a></li> </ul> </div> <div id="main"> <div id="ctxtnav" class="nav"> <h2>Context Navigation</h2> <ul> <li class="first"><span>← <a class="prev" href="/ticket/2392" title="Ticket #2392">Previous Ticket</a></span></li><li class="last"><span><a class="next" href="/ticket/2395" title="Ticket #2395">Next Ticket</a> →</span></li> </ul> <hr /> </div> <div id="content" class="ticket"> <div id="ticket" class="trac-content "> <div class="date"> <p>Opened <a class="timeline" href="/timeline?from=2013-08-24T00%3A28%3A41Z&precision=second" title="See timeline at 08/24/2013 12:28:41 AM">11 years ago</a></p> <p>Closed <a class="timeline" href="/timeline?from=2013-11-25T03%3A55%3A12Z&precision=second" title="See timeline at 11/25/2013 03:55:12 AM">11 years ago</a></p> <p>Last modified <a class="timeline" href="/timeline?from=2014-01-03T07%3A50%3A53Z&precision=second" title="See timeline at 01/03/2014 07:50:53 AM">11 years ago</a></p> </div> <h2> <a href="/ticket/2393" class="trac-id">#2393</a> <span class="trac-status"> <a href="/query?status=closed">closed</a> </span> <span class="trac-type"> <a href="/query?status=!closed&type=defect+(bug)">defect (bug)</a> </span> <span class="trac-resolution"> (<a href="/query?status=closed&resolution=fixed">fixed</a>) </span> </h2> <h1 id="trac-ticket-title" class="searchable"> <span class="summary">bbp_user_can_view_forum() and custom user ID</span> </h1> <table class="properties"> <tr> <th id="h_reporter">Reported by:</th> <td headers="h_reporter" class="searchable"> <a href="https://profiles.wordpress.org/alex-ye" data-nicename="alex-ye"> <img class="avatar" src="https://wordpress.org/grav-redirect.php?user=alex-ye&s=48" srcset="https://wordpress.org/grav-redirect.php?user=alex-ye&s=96 2x" height="48" width="48" alt="alex-ye's profile" /> </a> <a class="trac-author" href="/query?status=!closed&reporter=alex-ye">alex-ye</a></td> <th id="h_owner">Owned by:</th> <td headers="h_owner"> <a href="https://profiles.wordpress.org/johnjamesjacoby"> <img class="avatar" src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="johnjamesjacoby's profile" /> </a> <a class="trac-author" href="/query?status=!closed&owner=johnjamesjacoby">johnjamesjacoby</a></td> </tr> <tr> <th id="h_milestone"> Milestone: </th> <td headers="h_milestone"> <a class="closed milestone" href="/milestone/2.5" title="Completed 11 years ago (11/25/2013 06:27:23 AM)">2.5</a> </td> <th id="h_priority"> Priority: </th> <td headers="h_priority"> <a href="/query?status=!closed&priority=normal">normal</a> </td> </tr><tr> <th id="h_severity"> Severity: </th> <td headers="h_severity"> <a href="/query?status=!closed&severity=normal">normal</a> </td> <th id="h_version"> Version: </th> <td headers="h_version"> <a href="/query?status=!closed&version=2.3.2">2.3.2</a> </td> </tr><tr> <th id="h_component"> Component: </th> <td headers="h_component"> <a href="/query?status=!closed&component=Component+-+Users">Component - Users</a> </td> <th id="h_keywords"> Keywords: </th> <td headers="h_keywords" class="searchable"> <a href="/query?status=!closed&keywords=~has-patch">has-patch</a> </td> </tr><tr> <th id="h_cc" class="missing"> Cc: </th> <td headers="h_cc" class="searchable"> </td> <th class="missing"> </th> <td> </td> </tr> </table> <div class="description"> <h3 id="comment:description"> Description </h3> <div class="searchable"> <p>A small bug in <code>bbp_user_can_view_forum()</code> , it doesn't work properly with a custom user ID. because it doesn't pass the $user_id variable to <code>bbp_is_user_keymaster()</code> check. <br /></p> </div> </div></div> <div id="attachments"> <h3 class="foldable">Attachments <span class="trac-count">(2)</span></h3> <div class="attachments"> <dl class="attachments"> <dt> <a href="/attachment/ticket/2393/template.php.patch" title="View attachment">template.php.patch</a><a href="/raw-attachment/ticket/2393/template.php.patch" class="trac-rawlink" title="Download"></a> (<span title="854 bytes">854 bytes</span>) - added by <span class="trac-author">alex-ye</span> <a class="timeline" href="/timeline?from=2013-08-24T00%3A32%3A38Z&precision=second" title="See timeline at 08/24/2013 12:32:38 AM">11 years ago</a>. </dt> <dt> <a href="/attachment/ticket/2393/2393.patch" title="View attachment">2393.patch</a><a href="/raw-attachment/ticket/2393/2393.patch" class="trac-rawlink" title="Download"></a> (<span title="707 bytes">707 bytes</span>) - added by <span class="trac-author">alex-ye</span> <a class="timeline" href="/timeline?from=2013-09-03T04%3A26%3A00Z&precision=second" title="See timeline at 09/03/2013 04:26:00 AM">11 years ago</a>. </dt> </dl> <p> Download all attachments as: <a rel="nofollow" href="/zip-attachment/ticket/2393/">.zip</a> </p> </div> </div> <div> <div class="trac-noscript" style="position: relative"> <form id="prefs" method="get" action="/prefs" style="position: absolute; right: 0"> <div id="trac-comments-order"> <input type="radio" id="trac-comments-oldest" name="trac-comments-order" value="oldest" checked="checked" /> <label for="trac-comments-oldest">Oldest first</label> <input type="radio" id="trac-comments-newest" name="trac-comments-order" value="newest" /> <label for="trac-comments-newest">Newest first</label> <span id="trac-threaded-toggle" style="display: none"> <input type="radio" id="trac-comments-threaded" name="trac-comments-order" value="threaded" /> <label for="trac-comments-threaded">Threaded</label> </span> </div> <div> <input id="trac-show-comments-toggle" type="checkbox" checked="checked" /> <label for="trac-show-comments-toggle">Show comments</label> <input id="trac-show-property-changes-toggle" type="checkbox" /> <label for="trac-show-property-changes-toggle">Show property changes</label> </div> </form> </div> <h3 class="foldable">Change History <span class="trac-count">(18)</span></h3> <div id="changelog"> <div class="change"> <h3 class="change"> <span class="threading"> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/alex-ye" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=alex-ye&s=48" srcset="https://wordpress.org/grav-redirect.php?user=alex-ye&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="alex-ye" data-nicename="alex-ye"><span class="trac-author">alex-ye</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-08-24T00%3A32%3A38Z&precision=second" title="See timeline at 08/24/2013 12:32:38 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-attachment"> <strong class="trac-field-attachment">Attachment</strong> <a href="/attachment/ticket/2393/template.php.patch"><em>template.php.patch</em></a><a href="/raw-attachment/ticket/2393/template.php.patch" title="Download" class="trac-rawlink"></a> added </li> </ul> </div> <div class="change" id="trac-change-1-1377353402182867"> <h3 class="change"> <span class="threading"> <span id="comment:1" class="cnum"> <a href="#comment:1">#1</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-08-24T14%3A10%3A02Z&precision=second" title="See timeline at 08/24/2013 02:10:02 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> changed from <em>Awaiting Review</em> to <em>2.4</em> </li> </ul> <div class="comment searchable"> <p>Thanks for the patch. Committing.<br /></p> </div> </div> <div class="change" id="trac-change-2-1377353566469641"> <h3 class="change"> <span class="threading"> <span id="comment:2" class="cnum"> <a href="#comment:2">#2</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-08-24T14%3A12%3A46Z&precision=second" title="See timeline at 08/24/2013 02:12:46 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-owner"> <strong class="trac-field-owner">Owner</strong> set to <em>johnjamesjacoby</em> </li><li class="trac-field-resolution"> <strong class="trac-field-resolution">Resolution</strong> set to <em>fixed</em> </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>new</em> to <em>closed</em> </li> </ul> <div class="comment searchable"> <p>In <a class="changeset" href="/changeset/5087" title="In bbp_user_can_view_forum(), pass the $user_id into ...">5087</a>:<br /></p><div class="message"><p>In bbp_user_can_view_forum(), pass the $user_id into bbp_is_user_keymaster().<br /></p><p>Fixes issue where bbp_user_can_view_forum() may return incorrect results for users with the Keymaster role.<br /></p><p>Props alex-ye. Fixes <a class="closed ticket" href="/ticket/2393" title="#2393: defect (bug): bbp_user_can_view_forum() and custom user ID (closed: fixed)">#2393</a>.<br /></p></div> </div> </div> <div class="change"> <h3 class="change"> <span class="threading"> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/alex-ye" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=alex-ye&s=48" srcset="https://wordpress.org/grav-redirect.php?user=alex-ye&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="alex-ye" data-nicename="alex-ye"><span class="trac-author">alex-ye</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-09-03T04%3A26%3A00Z&precision=second" title="See timeline at 09/03/2013 04:26:00 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-attachment"> <strong class="trac-field-attachment">Attachment</strong> <a href="/attachment/ticket/2393/2393.patch"><em>2393.patch</em></a><a href="/raw-attachment/ticket/2393/2393.patch" title="Download" class="trac-rawlink"></a> added </li> </ul> </div> <div class="change" id="trac-change-3-1378182467098483"> <h3 class="change"> <span class="threading"> <span id="comment:3" class="cnum"> <a href="#comment:3">#3</a> </span> <span>follow-up:</span> <a href="#comment:6" class="follow-up">↓ 6</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/alex-ye" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=alex-ye&s=48" srcset="https://wordpress.org/grav-redirect.php?user=alex-ye&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="alex-ye" data-nicename="alex-ye"><span class="trac-author">alex-ye</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-09-03T04%3A27%3A47Z&precision=second" title="See timeline at 09/03/2013 04:27:47 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-resolution"> <strong class="trac-field-resolution">Resolution</strong> <em>fixed</em> deleted </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>closed</em> to <em>reopened</em> </li> </ul> <div class="comment searchable"> <p>The above patch fixing another bug when you pass <code>user_id</code> as zero.<br /></p> </div> </div> <div class="change" id="trac-change-4-1378190623460640"> <h3 class="change"> <span class="threading"> <span id="comment:4" class="cnum"> <a href="#comment:4">#4</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-09-03T06%3A43%3A43Z&precision=second" title="See timeline at 09/03/2013 06:43:43 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> <em>2.4</em> deleted </li> </ul> </div> <div class="change" id="trac-change-5-1378190753048229"> <h3 class="change"> <span class="threading"> <span id="comment:5" class="cnum"> <a href="#comment:5">#5</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-09-03T06%3A45%3A53Z&precision=second" title="See timeline at 09/03/2013 06:45:53 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> set to <em>Awaiting Review</em> </li> </ul> </div> <div class="change" id="trac-change-6-1378439707384167"> <h3 class="change"> <span class="threading"> <span id="comment:6" class="cnum"> <a href="#comment:6">#6</a> </span> in reply to: <a href="#comment:3">↑ 3</a> ; <span>follow-up:</span> <a href="#comment:7" class="follow-up">↓ 7</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-09-06T03%3A55%3A07Z&precision=second" title="See timeline at 09/06/2013 03:55:07 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> changed from <em>Awaiting Review</em> to <em>2.4.1</em> </li> </ul> <div class="comment searchable"> <p>Replying to <a class="ticket" href="/ticket/2393#comment:3" title="Comment 3">alex-ye</a>:<br /></p><blockquote class="citation"><p>The above patch fixing another bug when you pass <code>user_id</code> as zero.<br /></p></blockquote><p>What other bug does this fix?<br /></p> </div> </div> <div class="change" id="trac-change-7-1378469014177723"> <h3 class="change"> <span class="threading"> <span id="comment:7" class="cnum"> <a href="#comment:7">#7</a> </span> in reply to: <a href="#comment:6">↑ 6</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/alex-ye" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=alex-ye&s=48" srcset="https://wordpress.org/grav-redirect.php?user=alex-ye&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="alex-ye" data-nicename="alex-ye"><span class="trac-author">alex-ye</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-09-06T12%3A03%3A34Z&precision=second" title="See timeline at 09/06/2013 12:03:34 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Replying to <a class="ticket" href="/ticket/2393#comment:6" title="Comment 6">johnjamesjacoby</a>:<br /></p><blockquote class="citation"><p>Replying to <a class="ticket" href="/ticket/2393#comment:3" title="Comment 3">alex-ye</a>:<br /></p><blockquote class="citation"><p>The above patch fixing another bug when you pass <code>user_id</code> as zero.<br /></p></blockquote><p>What other bug does this fix?<br /></p></blockquote><p>The bbPress core doesn't call the the bbp_user_can_view_forum() with <code>user_id</code> as zero, but I face it when I was working on some client plug-in.<br /></p><p>When you pass the <code>user_id</code> as zero, the developers expect to refer to the current logged-in user ID like the other bbPress functions.<br /></p><p>so you can describe it as an enhancement.<br /></p> </div> </div> <div class="change" id="trac-change-8-1379782816636642"> <h3 class="change"> <span class="threading"> <span id="comment:8" class="cnum"> <a href="#comment:8">#8</a> </span> <span>follow-up:</span> <a href="#comment:9" class="follow-up">↓ 9</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-09-21T17%3A00%3A16Z&precision=second" title="See timeline at 09/21/2013 05:00:16 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Can you detail exactly what bug this causes and how to reproduce it?<br /></p> </div> </div> <div class="change" id="trac-change-9-1379841238190312"> <h3 class="change"> <span class="threading"> <span id="comment:9" class="cnum"> <a href="#comment:9">#9</a> </span> in reply to: <a href="#comment:8">↑ 8</a> ; <span>follow-up:</span> <a href="#comment:10" class="follow-up">↓ 10</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/alex-ye" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=alex-ye&s=48" srcset="https://wordpress.org/grav-redirect.php?user=alex-ye&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="alex-ye" data-nicename="alex-ye"><span class="trac-author">alex-ye</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-09-22T09%3A13%3A58Z&precision=second" title="See timeline at 09/22/2013 09:13:58 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Replying to <a class="ticket" href="/ticket/2393#comment:8" title="Comment 8">johnjamesjacoby</a>:<br /></p><blockquote class="citation"><p>Can you detail exactly what bug this causes and how to reproduce it?<br /></p></blockquote><p>It's simple, test this code with a private forum and an user with moderator role:<br /></p><pre class="wiki">echo bbp_user_can_view_forum( array( 'user_id' => 0, 'forum_id' => 94 ) );</pre> </div> </div> <div class="change" id="trac-change-10-1380308214064809"> <h3 class="change"> <span class="threading"> <span id="comment:10" class="cnum"> <a href="#comment:10">#10</a> </span> in reply to: <a href="#comment:9">↑ 9</a> ; <span>follow-up:</span> <a href="#comment:12" class="follow-up">↓ 12</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-09-27T18%3A56%3A54Z&precision=second" title="See timeline at 09/27/2013 06:56:54 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Replying to <a class="ticket" href="/ticket/2393#comment:9" title="Comment 9">alex-ye</a>:<br /></p><blockquote class="citation"><p>Replying to <a class="ticket" href="/ticket/2393#comment:8" title="Comment 8">johnjamesjacoby</a>:<br /></p><blockquote class="citation"><p>Can you detail exactly what bug this causes and how to reproduce it?<br /></p></blockquote><p>It's simple, test this code with a private forum and an user with moderator role:<br /></p><pre class="wiki">echo bbp_user_can_view_forum( array( 'user_id' => 0, 'forum_id' => 94 ) );</pre></blockquote><p>It's not simple, as I still don't understand what the actual bug is. My guess is that <code>bbp_user_can_view_forum</code> needs a fix, more than <code>bbp_get_user_id</code> needing a change in behavior that effects all of bbPress.<br /></p><p>If you're not passing a user_id into <code>bbp_user_can_view_forum()</code> then it should always return false, since returning true would be double-plus bad. How can a nonexistent user possibly access a forum?<br /></p> </div> </div> <div class="change" id="trac-change-11-1380748593856903"> <h3 class="change"> <span class="threading"> <span id="comment:11" class="cnum"> <a href="#comment:11">#11</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-10-02T21%3A16%3A33Z&precision=second" title="See timeline at 10/02/2013 09:16:33 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> changed from <em>2.4.1</em> to <em>2.5</em> </li> </ul> <div class="comment searchable"> <p>Unclear how to reproduce an unexpected circumstance, so moving to 2.5 for more reporter-feedback.<br /></p> </div> </div> <div class="change" id="trac-change-12-1380814604153423"> <h3 class="change"> <span class="threading"> <span id="comment:12" class="cnum"> <a href="#comment:12">#12</a> </span> in reply to: <a href="#comment:10">↑ 10</a> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/alex-ye" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=alex-ye&s=48" srcset="https://wordpress.org/grav-redirect.php?user=alex-ye&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="alex-ye" data-nicename="alex-ye"><span class="trac-author">alex-ye</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-10-03T15%3A36%3A44Z&precision=second" title="See timeline at 10/03/2013 03:36:44 PM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Replying to <a class="ticket" href="/ticket/2393#comment:10" title="Comment 10">johnjamesjacoby</a>:<br /></p><blockquote class="citation"><p>If you're not passing a user_id into <code>bbp_user_can_view_forum()</code> then it should always return false, since returning true would be double-plus bad.<br /></p></blockquote><p>Currently the function use the logged-in user ID if you don't pass <code>user_id</code> arg.. the bugs happens when you pass <code>user_id</code> arg as <code>0</code> only.<br /></p><p>What are those bugs?!<br />When the developer pass <code>user_id</code> as <code>0</code>, he may expect one of those results:<br /></p><p>1- The function will return false.<br />2- The function will replace the zero <code>user_id</code> with the logged-in user ID.<br /></p><p>but what actually happens is a mess! <br /></p><ul><li><code>$user_id</code> local variable will have <code>0</code> value.</li><li><code>bbp_is_user_keymaster( $user_id )</code> will check against the logged-in user ID.</li><li><code>user_can( $user_id, 'read_private_forums' )</code> check will return<code>false</code>.</li><li>And <code>apply_filters( 'bbp_user_can_view_forum', $retval, $forum_id, $user_id )</code></li></ul><p>Replying to <a class="ticket" href="/ticket/2393#comment:10" title="Comment 10">johnjamesjacoby</a>:<br /></p><blockquote class="citation"><p>How can a nonexistent user possibly access a forum?<br /></p></blockquote><p>Again, there is no security bug in the bbPress core! because bbPress core doesn't pass the <code>user_id</code> as zero with <code>bbp_user_can_view_forum()</code><br /></p><p>I hope you understand me :)<br /></p> </div> <div class="trac-lastedit "> Last edited <a class="timeline" href="/timeline?from=2013-10-03T15%3A38%3A55Z&precision=second" title="See timeline at 10/03/2013 03:38:55 PM">11 years ago</a> by <span class="trac-author">alex-ye</span> (<a href="/ticket/2393?cversion=0&cnum_hist=12#comment:12">previous</a>) (<a href="/ticket/2393?action=comment-diff&cnum=12&version=1">diff</a>) </div> </div> <div class="change" id="trac-change-13-1385350528453085"> <h3 class="change"> <span class="threading"> <span id="comment:13" class="cnum"> <a href="#comment:13">#13</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-25T03%3A35%3A28Z&precision=second" title="See timeline at 11/25/2013 03:35:28 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>In <a class="changeset" href="/changeset/5188" title="In `bbp_user_can_view_forum()` check the `$user_id` before passing it ...">5188</a>:<br /></p><div class="message"><p>In <code>bbp_user_can_view_forum()</code> check the <code>$user_id</code> before passing it into <code>bbp_is_user_keymaster()</code>. Prevents accidental role escalation if <code>$user_id</code> is empty. See <a class="closed ticket" href="/ticket/2393" title="#2393: defect (bug): bbp_user_can_view_forum() and custom user ID (closed: fixed)">#2393</a>.<br /></p></div> </div> </div> <div class="change" id="trac-change-14-1385350880875270"> <h3 class="change"> <span class="threading"> <span id="comment:14" class="cnum"> <a href="#comment:14">#14</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-25T03%3A41%3A20Z&precision=second" title="See timeline at 11/25/2013 03:41:20 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>In <a class="changeset" href="/changeset/5189" title="Check the `$author_id` before passing it into ...">5189</a>:<br /></p><div class="message"><p>Check the <code>$author_id</code> before passing it into <code>bbp_is_user_keymaster()</code> in blacklist and moderation functions. Prevents accidental role escalation if <code>$author_id</code> is empty. See <a class="closed ticket" href="/ticket/2393" title="#2393: defect (bug): bbp_user_can_view_forum() and custom user ID (closed: fixed)">#2393</a>.<br /></p></div> </div> </div> <div class="change" id="trac-change-15-1385351712496756"> <h3 class="change"> <span class="threading"> <span id="comment:15" class="cnum"> <a href="#comment:15">#15</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-25T03%3A55%3A12Z&precision=second" title="See timeline at 11/25/2013 03:55:12 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-resolution"> <strong class="trac-field-resolution">Resolution</strong> set to <em>fixed</em> </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>reopened</em> to <em>closed</em> </li> </ul> <div class="comment searchable"> <p>Marking this as closed.<br /></p><p>The two above changesets better reflect the intent of <code>bbp_is_user_keymaster()</code> checks, particularly inside of <code>bbp_user_can_view_forum()</code>. <br /></p><p>If an empty <code>$user_id</code> is explicitly passed as part of the <code>$args</code> array, we do not want to assume the developer intended it to be the current user ID (especially since the default value is already the current user ID.) This is to prevent accidental role escalation, since it is possible you'd want to check if an anonymous user can access a specific forum ID.<br /></p><p>If I've misunderstood you, please reopen (again) and place in the 2.6 milestone.<br /></p><p>Thanks for your diligence with this. :)<br /></p> </div> </div> <div class="change" id="trac-change-16-1385374821415395"> <h3 class="change"> <span class="threading"> <span id="comment:16" class="cnum"> <a href="#comment:16">#16</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/alex-ye" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=alex-ye&s=48" srcset="https://wordpress.org/grav-redirect.php?user=alex-ye&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="alex-ye" data-nicename="alex-ye"><span class="trac-author">alex-ye</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2013-11-25T10%3A20%3A21Z&precision=second" title="See timeline at 11/25/2013 10:20:21 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>Nice solution John, Always learn from you :)<br /></p> </div> </div> </div> </div> <div id="help"><strong>Note:</strong> See <a href="/wiki/TracTickets">TracTickets</a> for help on using tickets.</div> </div> <div id="altlinks"> <a class="preferences-link" href="/prefs">Trac UI Preferences</a> <h3>Download in other formats:</h3> <ul> <li class="first"> <a rel="nofollow" href="/ticket/2393?format=csv" class="csv">Comma-delimited Text</a> </li><li> <a rel="nofollow" href="/ticket/2393?format=tab" class="tab">Tab-delimited Text</a> </li><li class="last"> <a rel="nofollow" href="/ticket/2393?format=rss" class="rss">RSS Feed</a> </li> </ul></div> </div> <div id="footer"> <div class="links"> <p> See also: <a href="http://wordpress.org">WordPress.org</a> • <a href="http://bbpress.org">bbPress.org</a> • <a href="http://buddypress.org">BuddyPress.org</a> • <a href="http://ma.tt">Matt</a> • <a href="http://bbpress.org/feed/" title="RSS Feed for Articles">Blog RSS</a> </p> </div> <div class="details"> <p> <a href="http://twitter.com/bbpress" class="twitter">Follow bbPress on Twitter</a> • <a href="http://bbpress.org/about/gpl/">GPL</a> • <a href="http://bbpress.org/contact/">Contact Us</a> • <a href="http://bbpress.org/terms/">Terms of Service</a> </p> </div> </div> <script> var wpTracCurrentUser = "anonymous"; </script> <script src="https://s.w.org/style/js/navigation.min.js?20190128"></script> <script src="https://s.w.org/style/trac/jquery.caret.min.js?ver=2015-02-01"></script> <script src="https://s.w.org/style/trac/jquery.atwho.min.js?ver=1.0.1"></script> <script src="https://s.w.org/style/trac/wp-trac.js?220"></script> </body></html>
