<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"><html xmlns="http://www.w3.org/1999/xhtml"> <head> <title> #2528 (Topic Merge Freshness) – bbPress Trac </title> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> <meta http-equiv="X-UA-Compatible" content="IE=edge" /> <!--[if IE]><script type="text/javascript"> if (/^#__msie303:/.test(window.location.hash)) window.location.replace(window.location.hash.replace(/^#__msie303:/, '#')); </script><![endif]--> <link rel="search" href="/search" /> <link rel="prev" href="/ticket/2527" title="Ticket #2527" /> <link rel="last" href="/ticket/3609" title="Ticket #3609" /> <link rel="help" href="/wiki/TracGuide" /> <link rel="alternate" href="/ticket/2528?format=csv" type="text/csv" class="csv" title="Comma-delimited Text" /> <link rel="alternate" href="/ticket/2528?format=tab" type="text/tab-separated-values" class="tab" title="Tab-delimited Text" /> <link rel="alternate" href="/ticket/2528?format=rss" type="application/rss+xml" class="rss" title="RSS Feed" /> <link rel="next" href="/ticket/2529" title="Ticket #2529" /> <link rel="start" href="/wiki" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/trac.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/ticket.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/jquery-ui/jquery-ui.css?v=220" /> <link rel="stylesheet" href="https://s.w.org/style/trac/common/css/jquery-ui-addons.css?v=220" /> <link rel="icon" href="https://bbpress.org/favicon.ico" type="image/x-icon" /> <link rel="first" href="/ticket/1" title="Ticket #1" /> <style id="trac-noscript" type="text/css">.trac-noscript { display: none !important }</style> <link type="application/opensearchdescription+xml" rel="search" href="/search/opensearch" title="Search bbPress Trac" /> <script type="text/javascript"> var auto_preview_timeout=2.0; var form_token="f167bbd33531389a24f2148e"; var jquery_ui={"ampm":true,"date_format":"mm/dd/yy","day_names":{"abbreviated":["Sun","Mon","Tue","Wed","Thu","Fri","Sat"],"narrow":["Su","Mo","Tu","We","Th","Fr","Sa"],"wide":["Sunday","Monday","Tuesday","Wednesday","Thursday","Friday","Saturday"]},"default_timezone":null,"first_week_day":0,"month_names":{"abbreviated":["Jan","Feb","Mar","Apr","May","Jun","Jul","Aug","Sep","Oct","Nov","Dec"],"wide":["January","February","March","April","May","June","July","August","September","October","November","December"]},"period_names":{"am":["AM","AM"],"pm":["PM","PM"]},"show_timezone":false,"time_format":"hh:mm:ss TT","timepicker_separator":" ","timezone_iso8601":false,"timezone_list":null}; var comments_prefs={"comments_order":"oldest","show_comments":"true","show_prop_changes":"true"}; </script> <link rel="dns-prefetch" href="//fonts.googleapis.com" /> <link rel="dns-prefetch" href="//www.googletagmanager.com" /> <script>//<![CDATA[ (function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start': new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0], j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src= 'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); })(window,document,'script','dataLayer','GTM-P24PF4B'); //]]></script> <link rel="stylesheet" href="//fonts.googleapis.com/css?family=Open+Sans%3A300italic%2C400italic%2C600italic%2C300%2C400%2C600&subset=latin%2Clatin-ext&ver=3.8.1-alpha" type="text/css" media="all" /> <link type="text/css" media="screen" rel="stylesheet" href="//bbpress.org/wp-content/themes/bb-base/style.css?v=24" /> <link type="text/css" media="screen" rel="stylesheet" href="//bbpress.org/wp-content/themes/bb-base/style-bbpress.css?v=24" /> <meta name="viewport" content="width=device-width" /> <link rel="stylesheet" href="https://s.w.org/wp-includes/css/dashicons.min.css?20150710" type="text/css" /> <link rel="stylesheet" type="text/css" href="https://s.w.org/style/trac/wp-trac.css?220" /> <script src="https://s.w.org/style/trac/common/js/jquery.js?v=220"></script> <link rel="canonical" href="https://bbpress.trac.wordpress.org/ticket/2528" /> <script src="https://s.w.org/style/trac/common/js/babel.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/trac.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/search.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/folding.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/wikitoolbar.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/resizer.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/auto_preview.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui-addons.js?v=220"></script> <script src="https://s.w.org/style/trac/common/js/jquery-ui-i18n.js?v=220"></script> <script type="text/javascript"> jQuery("#trac-noscript").remove(); jQuery(document).ready(function($) { $(".trac-autofocus").focus(); $(".trac-target-new").attr("target", "_blank"); if ($.ui) { /* is jquery-ui added? */ $(".trac-datepicker:not([readonly])").prop("autocomplete", "off").datepicker(); $(".trac-datetimepicker:not([readonly])").prop("autocomplete", "off").datetimepicker(); $("#main").addClass("trac-nodatetimehint"); } $(".trac-disable").disableSubmit(".trac-disable-determinant"); setTimeout(function() { $(".trac-scroll").scrollToTop() }, 1); $(".trac-disable-on-submit").disableOnSubmit(); }); </script> <script src="https://s.w.org/style/trac/common/js/threaded_comments.js?v=220"></script> <script type="text/javascript"> jQuery(document).ready(function($) { $("div.description").find("h1,h2,h3,h4,h5,h6").addAnchor(_("Link to this section")); $(".foldable").enableFolding(false, true); /*<![CDATA[*/ $("#attachments").toggleClass("collapsed"); $("#trac-up-attachments").click(function () { $("#attachments").removeClass("collapsed"); return true; }); $("#modify").parent().toggleClass("collapsed"); $(".trac-topnav a").click(function() { $("#modify").parent().removeClass("collapsed"); }); function setRevertHandler() { $("button.trac-revert").click(function() { var div = $("div", this); var field_name = div[0].id.substr(7); var field_value = div.text(); var input = $("#propertyform *[name=field_" + field_name + "]"); if (input.length > 0) { if (input.filter("input[type=radio]").length > 0) { input.val([field_value]); } else if (input.filter("input[type=checkbox]").length > 0) { input.val(field_value == "1" ? [field_value] : []); } else { input.val(field_value); } } else { // Special case for CC checkbox input = $("#propertyform input[name=cc_update]").val([]); } input.change(); // Remove the revert button if ($(this).closest("tbody").children("tr").length === 1) $(this).closest(".trac-change-panel").remove(); else $(this).closest("tr").remove(); return false; }); } setRevertHandler(); var comment_focused = false; $("#comment").focus(function() { comment_focused = true; }) .blur(function() { comment_focused = false; }); $("#propertyform").autoSubmit({preview: '1'}, function(data, reply) { var items = $(reply); // Update ticket box $("#ticket").replaceWith(items.filter('#ticket')); // Replaces content of #changelog, without recreating it $("#changelog").empty().append(items.filter("#changelog").contents()); // Apply comments order and "Show" preferences applyCommentsOrder( $('#prefs input[name="trac-comments-order"]:checked').val()); // Show warning var new_changes = $("#changelog .trac-new"); $("#trac-edit-warning").toggle(new_changes.length != 0); if (new_changes.length != 0) $("#changelog").parent().show().removeClass("collapsed"); // Update view time $("#propertyform input[name='view_time']").replaceWith(items.filter("input[name='view_time']")); // Update preview var preview = $("#ticketchange").html(items.filter('#preview').children()); var show_preview = preview.children().length != 0; $("#ticketchange").toggle(show_preview); setRevertHandler(); // Execute scripts to load stylesheets items.filter("script").appendTo("head"); }, "#ticketchange .trac-loading"); $("#trac-comment-editor").autoSubmit({preview_comment: '1'}, function(data, reply) { var comment = $("#trac-comment-editor").next("div.comment").html(reply); comment.toggle(comment.children().length != 0); }, "#changelog .trac-loading"); /*]]>*/ }); </script> </head> <body id="wordpress-org" class="bbpress trac wporg-make make-bbpress"> <noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-P24PF4B" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript> <dl id="accessibility"> <dt>Skip to:</dt> <dd><a href="#content" title="Skip to content">Content</a></dd> </dl> <div id="wporg-header"> <div id="header-inner"> <button id="mobile-menu-button" aria-expanded="false"><span class="screen-reader-text">Toggle Menu</span></button> <ul id="wporg-header-menu"> <li><a href="https://bbpress.org/about/">About</a></li> <li><a href="https://bbpress.org/plugins/">Plugins</a></li> <li><a href="https://bbpress.org/themes/">Themes</a></li> <li><a href="https://codex.bbpress.org/">Documentation</a></li> <li><a href="https://bbpress.org/blog/">Blog</a></li> <li><a href="https://bbpress.org/forums/">Support</a></li> <li class="download"><a href="https://bbpress.org/download/">Download</a></li> </ul> <h1><a href="https://bbpress.org">bbPress.org</a></h1> </div> </div> <div id="subnav"> <div id="subnav-inner"> <ul id="nav-user" class="menu"> <li class="last first"> <a href="https://login.wordpress.org/?redirect_to=https%3A%2F%2Fbbpress.trac.wordpress.org%2Fticket%2F2528" class="login">Login</a></li> </ul> </div> </div> <div id="banner"> <form id="search" action="/search" method="get"> <div> <label for="proj-search">Search:</label> <input type="text" id="proj-search" name="q" size="18" value="" /> <input type="submit" value="Search" /> </div> </form> </div> <div id="mainnav" class="nav"> <ul> <li class="first"><a href="/timeline">Timeline</a></li><li class="active"><a href="/report">View Tickets</a></li><li><a href="/roadmap">Roadmap</a></li><li><a href="/browser">Browse Source</a></li><li class="last"><a href="/ticketgraph">Ticket Graph</a></li> </ul> </div> <div id="main"> <div id="ctxtnav" class="nav"> <h2>Context Navigation</h2> <ul> <li class="first"><span>← <a class="prev" href="/ticket/2527" title="Ticket #2527">Previous Ticket</a></span></li><li class="last"><span><a class="next" href="/ticket/2529" title="Ticket #2529">Next Ticket</a> →</span></li> </ul> <hr /> </div> <div id="content" class="ticket"> <div id="ticket" class="trac-content "> <div class="date"> <p>Opened <a class="timeline" href="/timeline?from=2014-01-25T06%3A34%3A25Z&precision=second" title="See timeline at 01/25/2014 06:34:25 AM">11 years ago</a></p> <p>Closed <a class="timeline" href="/timeline?from=2014-09-10T22%3A52%3A47Z&precision=second" title="See timeline at 09/10/2014 10:52:47 PM">10 years ago</a></p> </div> <h2> <a href="/ticket/2528" class="trac-id">#2528</a> <span class="trac-status"> <a href="/query?status=closed">closed</a> </span> <span class="trac-type"> <a href="/query?status=!closed&type=defect+(bug)">defect (bug)</a> </span> <span class="trac-resolution"> (<a href="/query?status=closed&resolution=fixed">fixed</a>) </span> </h2> <h1 id="trac-ticket-title" class="searchable"> <span class="summary">Topic Merge Freshness</span> </h1> <table class="properties"> <tr> <th id="h_reporter">Reported by:</th> <td headers="h_reporter" class="searchable"> <a href="https://profiles.wordpress.org/netweb" data-nicename="netweb"> <img class="avatar" src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="netweb's profile" /> </a> <a class="trac-author" href="/query?status=!closed&reporter=netweb">netweb</a></td> <th id="h_owner">Owned by:</th> <td headers="h_owner"> <a href="https://profiles.wordpress.org/netweb"> <img class="avatar" src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="netweb's profile" /> </a> <a class="trac-author" href="/query?status=!closed&owner=netweb">netweb</a></td> </tr> <tr> <th id="h_milestone"> Milestone: </th> <td headers="h_milestone"> <a class="closed milestone" href="/milestone/2.6" title="Completed 5 years ago (11/12/2019 05:00:00 PM)">2.6</a> </td> <th id="h_priority"> Priority: </th> <td headers="h_priority"> <a href="/query?status=!closed&priority=normal">normal</a> </td> </tr><tr> <th id="h_severity"> Severity: </th> <td headers="h_severity"> <a href="/query?status=!closed&severity=normal">normal</a> </td> <th id="h_version"> Version: </th> <td headers="h_version"> <a href="/query?status=!closed&version=2.5">2.5</a> </td> </tr><tr> <th id="h_component"> Component: </th> <td headers="h_component"> <a href="/query?status=!closed&component=Component+-+Topics">Component - Topics</a> </td> <th id="h_keywords"> Keywords: </th> <td headers="h_keywords" class="searchable"> <a href="/query?status=!closed&keywords=~needs-patch">needs-patch</a> <a href="/query?status=!closed&keywords=~needs-unit-tests">needs-unit-tests</a> </td> </tr><tr> <th id="h_cc" class="missing"> Cc: </th> <td headers="h_cc" class="searchable"> </td> <th class="missing"> </th> <td> </td> </tr> </table> <div class="description"> <h3 id="comment:description"> Description </h3> <div class="searchable"> <p>Merge Topic Fresness<br /></p><ul><li>Merge 'TopicB 2:00pm' topic into 'TopicA 1:00pm'</li><li>'TopicA' freshness is now 2:00pm</li><li>Merge 'TopicC 3:00pm' topic into 'TopicA 1:00pm'</li><li>'TopicA 1:00pm' topic freshness remains at 2:00pm</li></ul><p>Related: <a class="new ticket" href="/ticket/2329" title="#2329: defect (bug): The URLs of merged topics do not forward to the updated topic URL (new)">#2329</a><br /></p><p>See: <code>bbp_merge_topic_handler</code> and <code>bbp_merge_topic_count</code><br /></p> </div> </div></div> <div id="attachments"> <h3 class="foldable">Attachments <span class="trac-count">(2)</span></h3> <div class="attachments"> <dl class="attachments"> <dt> <a href="/attachment/ticket/2528/2528.1.diff" title="View attachment">2528.1.diff</a><a href="/raw-attachment/ticket/2528/2528.1.diff" class="trac-rawlink" title="Download"></a> (<span title="1665 bytes">1.6 KB</span>) - added by <span class="trac-author">netweb</span> <a class="timeline" href="/timeline?from=2014-06-17T14%3A10%3A18Z&precision=second" title="See timeline at 06/17/2014 02:10:18 PM">10 years ago</a>. </dt> <dt> <a href="/attachment/ticket/2528/2528.2.diff" title="View attachment">2528.2.diff</a><a href="/raw-attachment/ticket/2528/2528.2.diff" class="trac-rawlink" title="Download"></a> (<span title="2496 bytes">2.4 KB</span>) - added by <span class="trac-author">netweb</span> <a class="timeline" href="/timeline?from=2014-09-10T02%3A09%3A11Z&precision=second" title="See timeline at 09/10/2014 02:09:11 AM">10 years ago</a>. </dt> </dl> <p> Download all attachments as: <a rel="nofollow" href="/zip-attachment/ticket/2528/">.zip</a> </p> </div> </div> <div> <div class="trac-noscript" style="position: relative"> <form id="prefs" method="get" action="/prefs" style="position: absolute; right: 0"> <div id="trac-comments-order"> <input type="radio" id="trac-comments-oldest" name="trac-comments-order" value="oldest" checked="checked" /> <label for="trac-comments-oldest">Oldest first</label> <input type="radio" id="trac-comments-newest" name="trac-comments-order" value="newest" /> <label for="trac-comments-newest">Newest first</label> <span id="trac-threaded-toggle" style="display: none"> <input type="radio" id="trac-comments-threaded" name="trac-comments-order" value="threaded" /> <label for="trac-comments-threaded">Threaded</label> </span> </div> <div> <input id="trac-show-comments-toggle" type="checkbox" checked="checked" /> <label for="trac-show-comments-toggle">Show comments</label> <input id="trac-show-property-changes-toggle" type="checkbox" /> <label for="trac-show-property-changes-toggle">Show property changes</label> </div> </form> </div> <h3 class="foldable">Change History <span class="trac-count">(11)</span></h3> <div id="changelog"> <div class="change" id="trac-change-1-1396777803223810"> <h3 class="change"> <span class="threading"> <span id="comment:1" class="cnum"> <a href="#comment:1">#1</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-04-06T09%3A50%3A03Z&precision=second" title="See timeline at 04/06/2014 09:50:03 AM">11 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> changed from <em>Awaiting Review</em> to <em>Future Release</em> </li> </ul> <div class="comment searchable"> <p>Not a deal breaker, moving to future release pending a patch, then can be moved into an active milestone.<br /></p><p>Workaround: Use the repair tools to recalculate freshness.<br /></p> </div> </div> <div class="change" id="trac-change-2-1401507157570689"> <h3 class="change"> <span class="threading"> <span id="comment:2" class="cnum"> <a href="#comment:2">#2</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-05-31T03%3A32%3A37Z&precision=second" title="See timeline at 05/31/2014 03:32:37 AM">10 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-keywords"> <strong class="trac-field-keywords">Keywords</strong> <em>needs-patch</em> <em>needs-unit-tests</em> added </li><li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> changed from <em>Future Release</em> to <em>Awaiting Review</em> </li> </ul> <div class="comment searchable"> <p>Merging two topics:<br /></p><ul><li>1st topic 10am (post_date is 10am <code>2014-05-30 10:00:00</code>)</li><li>2nd topic 11am (post_date is 11am <code>2014-05-30 11:00:00</code>)</li></ul><p>If we merge the 11am topic into the 10am topic then <code>$destination_topic</code> of 10am is older than the <code>$source_topic</code> of 11am so the <code>$destination_topic</code> date should be updated to <code>2014-05-30 10:59:59</code><br /></p><p>Expected: Older topic (10am) post_date should now be updated to 10:59:59<br />Actual: No change to either topics post_date<br /></p><p>If you merge the 10am topic into the 11am topic then the 11am topic post_date is updated to <code>2014-05-30 09:59:59</code>, so we are doing it backwards to what we actually want.<br /></p><p>Relevant function <code>bbp_merge_topic_handler</code><br /></p><div class="wiki-code"><div class="code"><pre><span class="cp"><?php</span><span class="c1">// Check if the destination topic is older than the source topic</span><span class="k">if</span> <span class="p">(</span> <span class="nb">strtotime</span><span class="p">(</span> <span class="nv">$source_topic</span><span class="o">-></span><span class="na">post_date</span> <span class="p">)</span> <span class="o"><</span> <span class="nb">strtotime</span><span class="p">(</span> <span class="nv">$destination_topic</span><span class="o">-></span><span class="na">post_date</span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span> <span class="c1">// Set destination topic post_date to 1 second before source topic</span> <span class="nv">$destination_post_date</span> <span class="o">=</span> <span class="nb">date</span><span class="p">(</span> <span class="s1">'Y-m-d H:i:s'</span><span class="p">,</span> <span class="nb">strtotime</span><span class="p">(</span> <span class="nv">$source_topic</span><span class="o">-></span><span class="na">post_date</span> <span class="p">)</span> <span class="o">-</span> <span class="mi">1</span> <span class="p">);</span> <span class="c1">// Update destination topic</span> <span class="nx">wp_update_post</span><span class="p">(</span> <span class="k">array</span><span class="p">(</span> <span class="s1">'ID'</span> <span class="o">=></span> <span class="nv">$destination_topic_id</span><span class="p">,</span> <span class="s1">'post_date'</span> <span class="o">=></span> <span class="nv">$destination_post_date</span><span class="p">,</span> <span class="s1">'post_date_gmt'</span> <span class="o">=></span> <span class="nx">get_gmt_from_date</span><span class="p">(</span> <span class="nv">$destination_post_date</span> <span class="p">)</span> <span class="p">)</span> <span class="p">);</span><span class="p">}</span></pre></div></div><p>Currently we are actually <em>"Checking if the source topic <strong>less than</strong> than the destination topic"</em><br /></p><div class="wiki-code"><div class="code"><pre><span class="cp"><?php</span><span class="c1">// Check if the destination topic is older than the source topic</span><span class="k">if</span> <span class="p">(</span> <span class="nb">strtotime</span><span class="p">(</span> <span class="nv">$source_topic</span><span class="o">-></span><span class="na">post_date</span> <span class="p">)</span> <span class="o"><</span> <span class="nb">strtotime</span><span class="p">(</span> <span class="nv">$destination_topic</span><span class="o">-></span><span class="na">post_date</span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span></pre></div></div><p>It should be <em>"Checking if the source topic is <strong>greater than</strong> than the destination topic"</em><br /></p><div class="wiki-code"><div class="code"><pre><span class="cp"><?php</span><span class="c1">// Check if the destination topic is older than the source topic</span><span class="k">if</span> <span class="p">(</span> <span class="nb">strtotime</span><span class="p">(</span> <span class="nv">$source_topic</span><span class="o">-></span><span class="na">post_date</span> <span class="p">)</span> <span class="o">></span> <span class="nb">strtotime</span><span class="p">(</span> <span class="nv">$destination_topic</span><span class="o">-></span><span class="na">post_date</span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span></pre></div></div><p>Or maybe a clearer way to write the function based on the comment verbiage:<br /></p><div class="wiki-code"><div class="code"><pre><span class="cp"><?php</span><span class="c1">// Check if the destination topic is older than the source topic</span><span class="k">if</span> <span class="p">(</span> <span class="nb">strtotime</span><span class="p">(</span> <span class="nv">$destination_topic</span><span class="o">-></span><span class="na">post_date</span> <span class="p">)</span> <span class="o"><</span> <span class="nb">strtotime</span><span class="p">(</span> <span class="nv">$source_topic</span><span class="o">-></span><span class="na">post_date</span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span></pre></div></div><hr /><p>Now in theory if we merge two topics, the 1:20pm into 1:10pm per:<br /></p><ul><li><a class="missing ticket">#25596</a> May 30, 2014 at 1:10 pm Topic One Topic 1:10pm</li><li><a class="missing ticket">#25597</a> May 30, 2014 at 1:30 pm Topic One Reply 1:30pm</li><li><a class="missing ticket">#25598</a> May 30, 2014 at 1:50 pm Topic One Reply 1:50pm</li></ul><ul><li><a class="missing ticket">#25599</a> May 30, 2014 at 1:20 pm Topic Two Topic 1:20pm</li><li><a class="missing ticket">#25600</a> May 30, 2014 at 1:40 pm Topic Two Reply 1:40pm</li><li><a class="missing ticket">#25601</a> May 30, 2014 at 2:00 pm Topic Two Topic 2:00pm</li></ul><p>Expected Results:<br /></p><ul><li><a class="missing ticket">#25596</a> May 30, 2014 at 1:<strong>19</strong> pm Topic One Topic 1:10pm</li><li><a class="missing ticket">#25599</a> May 30, 2014 at 1:20 pm Topic Two Topic 1:20pm</li><li><a class="missing ticket">#25597</a> May 30, 2014 at 1:30 pm Topic One Reply 1:30pm</li><li><a class="missing ticket">#25600</a> May 30, 2014 at 1:40 pm Topic Two Reply 1:40pm</li><li><a class="missing ticket">#25598</a> May 30, 2014 at 1:50 pm Topic One Reply 1:50pm</li><li><a class="missing ticket">#25601</a> May 30, 2014 at 2:00 pm Topic Two Topic 2:00pm</li></ul><p>Actual results:<br /></p><ul><li><a class="missing ticket">#25596</a> May 30, 2014 at 1:19 pm Topic One Topic 1:10pm</li><li><a class="missing ticket">#25597</a> May 30, 2014 at 1:30 pm Topic One Reply 1:30pm</li><li><a class="missing ticket">#25598</a> May 30, 2014 at 1:50 pm Topic One Reply 1:50pm</li><li><a class="missing ticket">#25599</a> May 30, 2014 at 1:20 pm Topic Two Topic 1:20pm</li><li><a class="missing ticket">#25600</a> May 30, 2014 at 1:40 pm Topic Two Reply 1:40pm</li><li><a class="missing ticket">#25601</a> May 30, 2014 at 2:00 pm Topic Two Topic 2:00pm</li></ul><p>It looks like the replies from the source topic are not getting updated <code>menu_order</code><br /></p><table class="wiki"><tr><td>ID</td><td>post_date</td><td>post_content</td><td>post_name</td><td>post_type</td><td>post_parent</td><td style="text-align: left">menu_order </td></tr><tr><td>25596</td><td>2014-05-30 13:19:59</td><td>Topic One Topic 1:10pm</td><td>topic-one-topic-110pm</td><td>topic</td><td>25451</td><td>0</td></tr><tr><td>25597</td><td>2014-05-30 13:30:00</td><td>Topic One Reply 1:30pm</td><td>25597</td><td>reply</td><td>25596</td><td>1</td></tr><tr><td>25598</td><td>2014-05-30 13:50:00</td><td>Topic One Reply 1:50pm</td><td>25598</td><td>reply</td><td>25596</td><td>2</td></tr><tr><td>25599</td><td>2014-05-30 13:20:00</td><td>Topic Two Topic 1:20pm</td><td>reply-to-topic-one-topic-110pm</td><td>reply</td><td>25596</td><td>3</td></tr><tr><td>25600</td><td>2014-05-30 13:40:00</td><td>Topic Two Reply 1:40pm</td><td>reply-to-topic-one-topic-110pm-2</td><td>reply</td><td>25596</td><td>1</td><td> <- Source Reply</td></tr><tr><td>25601</td><td>2014-05-30 14:00:00</td><td>Topic Two Topic 2:00pm</td><td>reply-to-topic-one-topic-110pm-3</td><td>reply</td><td>25596</td><td>2</td><td> <- Source Reply</td></tr></table> </div> </div> <div class="change" id="trac-change-3-1402529517075224"> <h3 class="change"> <span class="threading"> <span id="comment:3" class="cnum"> <a href="#comment:3">#3</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-06-11T23%3A31%3A57Z&precision=second" title="See timeline at 06/11/2014 11:31:57 PM">10 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-milestone"> <strong class="trac-field-milestone">Milestone</strong> changed from <em>Awaiting Review</em> to <em>2.6</em> </li><li class="trac-field-owner"> <strong class="trac-field-owner">Owner</strong> set to <em>netweb</em> </li> </ul> </div> <div class="change" id="trac-change-4-1402846979258775"> <h3 class="change"> <span class="threading"> <span id="comment:4" class="cnum"> <a href="#comment:4">#4</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-06-15T15%3A42%3A59Z&precision=second" title="See timeline at 06/15/2014 03:42:59 PM">10 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-resolution"> <strong class="trac-field-resolution">Resolution</strong> set to <em>fixed</em> </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>new</em> to <em>closed</em> </li> </ul> <div class="comment searchable"> <p>In <a class="changeset" href="/changeset/5404" title="Correctly compare source & destination topic `post_date` values in ...">5404</a>:<br /></p><div class="message"><p>Correctly compare source & destination topic <code>post_date</code> values in <code>bbp_merge_topic_handler()</code>. Fixes issue where incorrect post would be updated when merging older topics into newer ones.<br /></p><p>Also update the reply position for all newly relocated replies. Hat-tip netweb. Fixes <a class="closed ticket" href="/ticket/2528" title="#2528: defect (bug): Topic Merge Freshness (closed: fixed)">#2528</a>.<br /></p></div> </div> </div> <div class="change"> <h3 class="change"> <span class="threading"> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-06-17T14%3A10%3A18Z&precision=second" title="See timeline at 06/17/2014 02:10:18 PM">10 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-attachment"> <strong class="trac-field-attachment">Attachment</strong> <a href="/attachment/ticket/2528/2528.1.diff"><em>2528.1.diff</em></a><a href="/raw-attachment/ticket/2528/2528.1.diff" title="Download" class="trac-rawlink"></a> added </li> </ul> </div> <div class="change" id="trac-change-5-1403014294818967"> <h3 class="change"> <span class="threading"> <span id="comment:5" class="cnum"> <a href="#comment:5">#5</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-06-17T14%3A11%3A34Z&precision=second" title="See timeline at 06/17/2014 02:11:34 PM">10 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-resolution"> <strong class="trac-field-resolution">Resolution</strong> <em>fixed</em> deleted </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>closed</em> to <em>reopened</em> </li> </ul> <div class="comment searchable"> <p>This is still not quite right:<br /></p><ul><li>Merged replies and source topic topic are assigned a post title</li><li>Merged replies and source topic topic are assigned a post name</li><li>Reply <code>menu_order</code> is assigned the old source topic <code>menu_order</code> rather than destination <code>menu_order</code><ul><li><em>(i.e. Don't update <code>menu_order</code> until after the <code>post_parent</code> has been updated)</em></li></ul></li></ul><p>Attached patch 2528.1.diff addresses the above and also removes source topic's last and count meta data.<br /></p><hr /><p>The above patch <strong><em>only</em></strong> fully works alongside patch 2623.1.diff in <a class="closed ticket" href="/ticket/2623" title="#2623: defect (bug): Reply To functions parameter order (closed: invalid)">#2623</a>, specifics details are in that ticket, without 2623.1.diff <code>reply_to</code> values are created of themselves in post meta for merged replies.<br /></p><p>Related: <a class="closed ticket" href="/ticket/2623" title="#2623: defect (bug): Reply To functions parameter order (closed: invalid)">#2623</a><br /></p><hr /><p>Also because our source topic <code>post_name</code> after merging get's an updated post meta key <code>_wp_old_slug</code> that is a <a class="wiki" href="/wiki/WordPress">WordPress</a> 301 redirect using the old slug to the new slug this should allow us to forward the URL of reply notifications from the old topic per <a class="new ticket" href="/ticket/2329" title="#2329: defect (bug): The URLs of merged topics do not forward to the updated topic URL (new)">#2329</a> if <a class="new ticket" href="/ticket/2424" title="#2424: enhancement: Redirect single replies to parent topic (new)">#2424</a> is implemented.<br /></p><p>Related: <a class="new ticket" href="/ticket/2329" title="#2329: defect (bug): The URLs of merged topics do not forward to the updated topic URL (new)">#2329</a> <a class="new ticket" href="/ticket/2424" title="#2424: enhancement: Redirect single replies to parent topic (new)">#2424</a><br /></p><hr /><p>Similar issues to the above are also needed for the 'Split Topic' function, see <a class="closed ticket" href="/ticket/2624" title="#2624: defect (bug): Split topics function updates including reply position and reply title (closed: fixed)">#2624</a><br /></p> </div> </div> <div class="change"> <h3 class="change"> <span class="threading"> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-09-10T02%3A09%3A11Z&precision=second" title="See timeline at 09/10/2014 02:09:11 AM">10 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-attachment"> <strong class="trac-field-attachment">Attachment</strong> <a href="/attachment/ticket/2528/2528.2.diff"><em>2528.2.diff</em></a><a href="/raw-attachment/ticket/2528/2528.2.diff" title="Download" class="trac-rawlink"></a> added </li> </ul> </div> <div class="change" id="trac-change-6-1410387505091593"> <h3 class="change"> <span class="threading"> <span id="comment:6" class="cnum"> <a href="#comment:6">#6</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/netweb" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=netweb&s=48" srcset="https://wordpress.org/grav-redirect.php?user=netweb&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="netweb" data-nicename="netweb"><span class="trac-author">netweb</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-09-10T22%3A18%3A25Z&precision=second" title="See timeline at 09/10/2014 10:18:25 PM">10 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>In <a class="ext-link" href="https://bbpress.trac.wordpress.org/attachment/ticket/2528/2528.2.diff"><span class="icon"></span>2528.2.diff</a> refreshes 2528.1.diff with the following additions:<br /></p><ul><li>Reverts <a class="changeset" href="/changeset/5404" title="Correctly compare source & destination topic `post_date` values in ...">r5404</a> <code>strtotime</code> - Antiprops netweb. (I blame the <em>epoch's</em>, long detailed description available if req.)</li><li>Removes the <code>bbp_update_reply_to()</code> <em>"adjust reply to values"</em> reply to updates, a threaded reply is always a reply to a reply, if we move a reply as part of a merge any reply to another reply will still be a reply to the same reply ID.</li></ul><p>Patch 2528.2.diff fully tested with 'non-threaded' and "thread replies" -> <a class="ext-link" href="https://cloudup.com/cvnzD1f85HG"><span class="icon"></span>https://cloudup.com/cvnzD1f85HG</a><br /></p> </div> </div> <div class="change" id="trac-change-7-1410388786363482"> <h3 class="change"> <span class="threading"> <span id="comment:7" class="cnum"> <a href="#comment:7">#7</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-09-10T22%3A39%3A46Z&precision=second" title="See timeline at 09/10/2014 10:39:46 PM">10 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <div class="comment searchable"> <p>In <a class="ext-link" href="https://bbpress.trac.wordpress.org/attachment/ticket/2528/2528.2.diff"><span class="icon"></span>2528.2.diff</a> why set the <code>post_name</code> to <code>$reply->ID</code>? We seem to set it to false everywhere else, and let <code>wp_update_post()</code> take care of the slug for us.<br /></p> </div> </div> <div class="change" id="trac-change-8-1410389221966242"> <h3 class="change chat-bot"> <span class="avatar"> <span class="username-line"> <img src="https://wordpress.org/grav-redirect.php?user=ircbot&s=48" srcset="https://wordpress.org/grav-redirect.php?user=ircbot&s=96 2x" height="48" width="48" alt="" /> <p><em>This ticket was mentioned in IRC in #bbpress-dev by jjj. <a class="ext-link" href="http://irclogs.wordpress.org/chanlog.php?channel=bbpress-dev&day=2014-09-10&sort=asc#m22475"><span class="icon"></span>View the logs</a>.</em><br /></p> </span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-09-10T22%3A47%3A01Z&precision=second" title="See timeline at 09/10/2014 10:47:01 PM">10 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> </div> <div class="change" id="trac-change-9-1410389567194163"> <h3 class="change"> <span class="threading"> <span id="comment:9" class="cnum"> <a href="#comment:9">#9</a> </span> </span> <span class="avatar"> <span class="username-line"><a href="https://profiles.wordpress.org/johnjamesjacoby" class="profile-link"> <img src="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=48" srcset="https://wordpress.org/grav-redirect.php?user=johnjamesjacoby&s=96 2x" height="48" width="48" alt="" /> @<span class="username" data-username="johnjamesjacoby" data-nicename="johnjamesjacoby"><span class="trac-author">johnjamesjacoby</span></span></a></span> <br /><span class="time-ago"><a class="timeline" href="/timeline?from=2014-09-10T22%3A52%3A47Z&precision=second" title="See timeline at 09/10/2014 10:52:47 PM">10 years</a> ago</span> </span> <div class="trac-ticket-buttons"> </div> </h3> <div class="trac-ticket-buttons"></div> <ul class="changes"> <li class="trac-field-resolution"> <strong class="trac-field-resolution">Resolution</strong> set to <em>fixed</em> </li><li class="trac-field-status"> <strong class="trac-field-status">Status</strong> changed from <em>reopened</em> to <em>closed</em> </li> </ul> <div class="comment searchable"> <p>In <a class="changeset" href="/changeset/5489" title="In `bbp_merge_topic_handler()` delete last and count metas, and update ...">5489</a>:<br /></p><div class="message"><p>In <code>bbp_merge_topic_handler()</code> delete last and count metas, and update the reply position after call to <code>wp_update_post()</code>. Fixes bug where merging two topics with odd timestamps could result in orphaned or incorrect meta data and hierarchy positioning. Props netweb. Fixes <a class="closed ticket" href="/ticket/2528" title="#2528: defect (bug): Topic Merge Freshness (closed: fixed)">#2528</a>.<br /></p></div> </div> </div> </div> </div> <div id="help"><strong>Note:</strong> See <a href="/wiki/TracTickets">TracTickets</a> for help on using tickets.</div> </div> <script type="text/javascript"> jQuery.loadStyleSheet("/pygments/trac.css", "text/css"); </script> <div id="altlinks"> <a class="preferences-link" href="/prefs">Trac UI Preferences</a> <h3>Download in other formats:</h3> <ul> <li class="first"> <a rel="nofollow" href="/ticket/2528?format=csv" class="csv">Comma-delimited Text</a> </li><li> <a rel="nofollow" href="/ticket/2528?format=tab" class="tab">Tab-delimited Text</a> </li><li class="last"> <a rel="nofollow" href="/ticket/2528?format=rss" class="rss">RSS Feed</a> </li> </ul></div> </div> <div id="footer"> <div class="links"> <p> See also: <a href="http://wordpress.org">WordPress.org</a> • <a href="http://bbpress.org">bbPress.org</a> • <a href="http://buddypress.org">BuddyPress.org</a> • <a href="http://ma.tt">Matt</a> • <a href="http://bbpress.org/feed/" title="RSS Feed for Articles">Blog RSS</a> </p> </div> <div class="details"> <p> <a href="http://twitter.com/bbpress" class="twitter">Follow bbPress on Twitter</a> • <a href="http://bbpress.org/about/gpl/">GPL</a> • <a href="http://bbpress.org/contact/">Contact Us</a> • <a href="http://bbpress.org/terms/">Terms of Service</a> </p> </div> </div> <script> var wpTracCurrentUser = "anonymous"; </script> <script src="https://s.w.org/style/js/navigation.min.js?20190128"></script> <script src="https://s.w.org/style/trac/jquery.caret.min.js?ver=2015-02-01"></script> <script src="https://s.w.org/style/trac/jquery.atwho.min.js?ver=1.0.1"></script> <script src="https://s.w.org/style/trac/wp-trac.js?220"></script> </body></html>
